Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc

Issue 2568033005: [NTP::SectionOrder] Replace CategoryFactory with a category ranker. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc
diff --git a/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc b/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc
index 27ac0a2efee7c070fe71981ad46f0b1da1bf3161..f24cf7f9d8a95dc6dcd1c9f25d5eeceef7586438 100644
--- a/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc
+++ b/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc
@@ -26,7 +26,7 @@
#include "components/image_fetcher/image_decoder.h"
#include "components/image_fetcher/image_fetcher.h"
#include "components/image_fetcher/image_fetcher_delegate.h"
-#include "components/ntp_snippets/category_factory.h"
+#include "components/ntp_snippets/category.h"
#include "components/ntp_snippets/category_info.h"
#include "components/ntp_snippets/ntp_snippets_constants.h"
#include "components/ntp_snippets/pref_names.h"
@@ -35,6 +35,8 @@
#include "components/ntp_snippets/remote/ntp_snippets_scheduler.h"
#include "components/ntp_snippets/remote/remote_suggestions_database.h"
#include "components/ntp_snippets/remote/test_utils.h"
+#include "components/ntp_snippets/section_rankers/default_constant_section_ranker.h"
+#include "components/ntp_snippets/section_rankers/section_ranker.h"
#include "components/ntp_snippets/user_classifier.h"
#include "components/prefs/testing_pref_service.h"
#include "components/signin/core/browser/fake_profile_oauth2_token_service.h"
@@ -401,6 +403,7 @@ class RemoteSuggestionsProviderTest : public ::testing::Test {
fake_url_fetcher_factory_(
/*default_factory=*/&failing_url_fetcher_factory_),
test_url_(kTestContentSuggestionsServerWithAPIKey),
+ section_ranker_(base::MakeUnique<DefaultConstantSectionRanker>()),
user_classifier_(/*pref_service=*/nullptr),
image_fetcher_(nullptr),
image_decoder_(nullptr) {
@@ -436,9 +439,8 @@ class RemoteSuggestionsProviderTest : public ::testing::Test {
std::unique_ptr<NTPSnippetsFetcher> snippets_fetcher =
base::MakeUnique<NTPSnippetsFetcher>(
utils_.fake_signin_manager(), fake_token_service_.get(),
- std::move(request_context_getter), utils_.pref_service(),
- &category_factory_, nullptr, base::Bind(&ParseJson), kAPIKey,
- &user_classifier_);
+ std::move(request_context_getter), utils_.pref_service(), nullptr,
+ base::Bind(&ParseJson), kAPIKey, &user_classifier_);
utils_.fake_signin_manager()->SignIn("foo@bar.com");
@@ -451,7 +453,7 @@ class RemoteSuggestionsProviderTest : public ::testing::Test {
EXPECT_FALSE(observer_);
observer_ = base::MakeUnique<FakeContentSuggestionsProviderObserver>();
return base::MakeUnique<RemoteSuggestionsProvider>(
- observer_.get(), &category_factory_, utils_.pref_service(), "fr",
+ observer_.get(), utils_.pref_service(), "fr", section_ranker_.get(),
&user_classifier_, &scheduler_, std::move(snippets_fetcher),
std::move(image_fetcher), std::move(image_decoder),
base::MakeUnique<RemoteSuggestionsDatabase>(database_dir_.GetPath(),
@@ -487,17 +489,17 @@ class RemoteSuggestionsProviderTest : public ::testing::Test {
}
Category articles_category() {
- return category_factory_.FromKnownCategory(KnownCategories::ARTICLES);
+ return Category::FromKnownCategory(KnownCategories::ARTICLES);
}
ContentSuggestion::ID MakeOtherID(const std::string& id_within_category) {
return ContentSuggestion::ID(other_category(), id_within_category);
}
- Category other_category() { return category_factory_.FromRemoteCategory(2); }
+ Category other_category() { return Category::FromRemoteCategory(2); }
Category unknown_category() {
- return category_factory_.FromRemoteCategory(kUnknownRemoteCategoryId);
+ return Category::FromRemoteCategory(kUnknownRemoteCategoryId);
}
protected:
@@ -542,10 +544,10 @@ class RemoteSuggestionsProviderTest : public ::testing::Test {
net::FakeURLFetcherFactory fake_url_fetcher_factory_;
const GURL test_url_;
std::unique_ptr<OAuth2TokenService> fake_token_service_;
+ std::unique_ptr<SectionRanker> section_ranker_;
UserClassifier user_classifier_;
NiceMock<MockScheduler> scheduler_;
std::unique_ptr<FakeContentSuggestionsProviderObserver> observer_;
- CategoryFactory category_factory_;
NiceMock<MockImageFetcher>* image_fetcher_;
FakeImageDecoder* image_decoder_;

Powered by Google App Engine
This is Rietveld 408576698