Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: components/ntp_snippets/remote/ntp_snippets_fetcher.cc

Issue 2568033005: [NTP::SectionOrder] Replace CategoryFactory with a category ranker. (Closed)
Patch Set: rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/ntp_snippets_fetcher.cc
diff --git a/components/ntp_snippets/remote/ntp_snippets_fetcher.cc b/components/ntp_snippets/remote/ntp_snippets_fetcher.cc
index 8b437e18ce4141e665cc5273516ba6f28e6ac33a..4ba1451b564dab8ca9830dec513eae47e2392afd 100644
--- a/components/ntp_snippets/remote/ntp_snippets_fetcher.cc
+++ b/components/ntp_snippets/remote/ntp_snippets_fetcher.cc
@@ -24,7 +24,7 @@
#include "base/time/time.h"
#include "base/values.h"
#include "components/data_use_measurement/core/data_use_user_data.h"
-#include "components/ntp_snippets/category_factory.h"
+#include "components/ntp_snippets/category.h"
#include "components/ntp_snippets/features.h"
#include "components/ntp_snippets/ntp_snippets_constants.h"
#include "components/ntp_snippets/user_classifier.h"
@@ -423,7 +423,6 @@ NTPSnippetsFetcher::NTPSnippetsFetcher(
OAuth2TokenService* token_service,
scoped_refptr<URLRequestContextGetter> url_request_context_getter,
PrefService* pref_service,
- CategoryFactory* category_factory,
LanguageModel* language_model,
const ParseJSONCallback& parse_json_callback,
const std::string& api_key,
@@ -432,7 +431,6 @@ NTPSnippetsFetcher::NTPSnippetsFetcher(
signin_manager_(signin_manager),
token_service_(token_service),
url_request_context_getter_(std::move(url_request_context_getter)),
- category_factory_(category_factory),
language_model_(language_model),
parse_json_callback_(parse_json_callback),
fetch_url_(GetFetchEndpoint()),
@@ -1047,7 +1045,7 @@ bool NTPSnippetsFetcher::JsonToSnippets(const base::Value& parsed,
case FetchAPI::CHROME_READER_API: {
const int kUnusedRemoteCategoryId = -1;
categories->push_back(FetchedCategory(
- category_factory_->FromKnownCategory(KnownCategories::ARTICLES),
+ Category::FromKnownCategory(KnownCategories::ARTICLES),
BuildArticleCategoryInfo(base::nullopt)));
const base::ListValue* recos = nullptr;
@@ -1085,8 +1083,7 @@ bool NTPSnippetsFetcher::JsonToSnippets(const base::Value& parsed,
return false;
}
}
- Category category =
- category_factory_->FromRemoteCategory(remote_category_id);
+ Category category = Category::FromRemoteCategory(remote_category_id);
if (category.IsKnownCategory(KnownCategories::ARTICLES)) {
categories->push_back(FetchedCategory(
category,
« no previous file with comments | « components/ntp_snippets/remote/ntp_snippets_fetcher.h ('k') | components/ntp_snippets/remote/ntp_snippets_fetcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698