Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc

Issue 2568033005: [NTP::SectionOrder] Replace CategoryFactory with a category ranker. (Closed)
Patch Set: rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc
diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc
index dd91fab4cf58cef30818031e13b9e31a6f300737..763abe01cd5995d3145c8c4a63dee9ba8051fa22 100644
--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc
+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc
@@ -14,7 +14,6 @@
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "components/ntp_snippets/category.h"
-#include "components/ntp_snippets/category_factory.h"
#include "components/ntp_snippets/content_suggestions_provider.h"
#include "components/ntp_snippets/mock_content_suggestions_provider_observer.h"
#include "components/ntp_snippets/offline_pages/offline_pages_test_utils.h"
@@ -97,16 +96,14 @@ class PhysicalWebPageSuggestionsProviderTest : public testing::Test {
PhysicalWebPageSuggestionsProvider* CreateProvider() {
DCHECK(!provider_);
provider_ = base::MakeUnique<PhysicalWebPageSuggestionsProvider>(
- &observer_, &category_factory_, &physical_web_data_source_,
- pref_service_.get());
+ &observer_, &physical_web_data_source_, pref_service_.get());
return provider_.get();
}
void DestroyProvider() { provider_.reset(); }
Category provided_category() {
- return category_factory_.FromKnownCategory(
- KnownCategories::PHYSICAL_WEB_PAGES);
+ return Category::FromKnownCategory(KnownCategories::PHYSICAL_WEB_PAGES);
}
ContentSuggestion::ID GetDummySuggestionId(int id) {
@@ -141,7 +138,6 @@ class PhysicalWebPageSuggestionsProviderTest : public testing::Test {
private:
FakePhysicalWebDataSource physical_web_data_source_;
StrictMock<MockContentSuggestionsProviderObserver> observer_;
- CategoryFactory category_factory_;
std::unique_ptr<TestingPrefServiceSimple> pref_service_;
// Added in order to test provider's |Fetch| method.
base::MessageLoop message_loop_;

Powered by Google App Engine
This is Rietveld 408576698