Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: components/ntp_snippets/category_unittest.cc

Issue 2568033005: [NTP::SectionOrder] Replace CategoryFactory with a category ranker. (Closed)
Patch Set: rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/category_unittest.cc
diff --git a/components/ntp_snippets/category_unittest.cc b/components/ntp_snippets/category_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8ae1c5f88eb8d0ee2d6ba24c7614143f6b14cd28
--- /dev/null
+++ b/components/ntp_snippets/category_unittest.cc
@@ -0,0 +1,41 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/ntp_snippets/category.h"
+
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace ntp_snippets {
+
+TEST(CategoryTest, FromKnownCategoryShouldReturnSameCategoryForSameInput) {
+ const KnownCategories known_category = KnownCategories::BOOKMARKS;
+ Category first = Category::FromKnownCategory(known_category);
+ Category second = Category::FromKnownCategory(known_category);
+ EXPECT_EQ(first, second);
+}
+
+TEST(CategoryFactoryTest,
+ FromRemoteCategoryShouldReturnSameCategoryForSameInput) {
+ const int remote_category_id = 123;
+ Category first = Category::FromRemoteCategory(remote_category_id);
+ Category second = Category::FromRemoteCategory(remote_category_id);
+ EXPECT_EQ(first, second);
+}
+
+TEST(CategoryFactoryTest, FromIDValueShouldReturnSameKnownCategory) {
+ Category known_category =
+ Category::FromKnownCategory(KnownCategories::BOOKMARKS);
+ Category known_category_by_id = Category::FromIDValue(known_category.id());
+ EXPECT_EQ(known_category, known_category_by_id);
+}
+
+TEST(CategoryFactoryTest, FromIDValueShouldReturnSameRemoteCategory) {
+ const int remote_category_id = 123;
+ Category remote_category = Category::FromRemoteCategory(remote_category_id);
+ Category remote_category_by_id = Category::FromIDValue(remote_category.id());
+ EXPECT_EQ(remote_category, remote_category_by_id);
+}
+
+} // namespace ntp_snippets

Powered by Google App Engine
This is Rietveld 408576698