Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: chrome/browser/ntp_snippets/download_suggestions_provider.cc

Issue 2568033005: [NTP::SectionOrder] Replace CategoryFactory with a category ranker. (Closed)
Patch Set: rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ntp_snippets/download_suggestions_provider.h" 5 #include "chrome/browser/ntp_snippets/download_suggestions_provider.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 OfflinePageModelQueryBuilder builder; 122 OfflinePageModelQueryBuilder builder;
123 builder.RequireSupportedByDownload( 123 builder.RequireSupportedByDownload(
124 OfflinePageModelQuery::Requirement::INCLUDE_MATCHING); 124 OfflinePageModelQuery::Requirement::INCLUDE_MATCHING);
125 return builder.Build(model->GetPolicyController()); 125 return builder.Build(model->GetPolicyController());
126 } 126 }
127 127
128 } // namespace 128 } // namespace
129 129
130 DownloadSuggestionsProvider::DownloadSuggestionsProvider( 130 DownloadSuggestionsProvider::DownloadSuggestionsProvider(
131 ContentSuggestionsProvider::Observer* observer, 131 ContentSuggestionsProvider::Observer* observer,
132 ntp_snippets::CategoryFactory* category_factory,
133 offline_pages::OfflinePageModel* offline_page_model, 132 offline_pages::OfflinePageModel* offline_page_model,
134 content::DownloadManager* download_manager, 133 content::DownloadManager* download_manager,
135 PrefService* pref_service, 134 PrefService* pref_service,
136 bool download_manager_ui_enabled) 135 bool download_manager_ui_enabled)
137 : ContentSuggestionsProvider(observer, category_factory), 136 : ContentSuggestionsProvider(observer),
138 category_status_(CategoryStatus::AVAILABLE_LOADING), 137 category_status_(CategoryStatus::AVAILABLE_LOADING),
139 provided_category_(category_factory->FromKnownCategory( 138 provided_category_(Category::FromKnownCategory(
140 ntp_snippets::KnownCategories::DOWNLOADS)), 139 ntp_snippets::KnownCategories::DOWNLOADS)),
141 offline_page_model_(offline_page_model), 140 offline_page_model_(offline_page_model),
142 download_manager_(download_manager), 141 download_manager_(download_manager),
143 pref_service_(pref_service), 142 pref_service_(pref_service),
144 download_manager_ui_enabled_(download_manager_ui_enabled), 143 download_manager_ui_enabled_(download_manager_ui_enabled),
145 weak_ptr_factory_(this) { 144 weak_ptr_factory_(this) {
146 observer->OnCategoryStatusChanged(this, provided_category_, category_status_); 145 observer->OnCategoryStatusChanged(this, provided_category_, category_status_);
147 146
148 DCHECK(offline_page_model_ || download_manager_); 147 DCHECK(offline_page_model_ || download_manager_);
149 if (offline_page_model_) { 148 if (offline_page_model_) {
(...skipping 662 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 void DownloadSuggestionsProvider::UnregisterDownloadItemObservers() { 811 void DownloadSuggestionsProvider::UnregisterDownloadItemObservers() {
813 DCHECK_NE(download_manager_, nullptr); 812 DCHECK_NE(download_manager_, nullptr);
814 813
815 std::vector<DownloadItem*> all_downloads; 814 std::vector<DownloadItem*> all_downloads;
816 download_manager_->GetAllDownloads(&all_downloads); 815 download_manager_->GetAllDownloads(&all_downloads);
817 816
818 for (DownloadItem* item : all_downloads) { 817 for (DownloadItem* item : all_downloads) {
819 item->RemoveObserver(this); 818 item->RemoveObserver(this);
820 } 819 }
821 } 820 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698