Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 256803012: extensions::Dispatcher: Don't crash if forced_idle_timer_ is null. (Closed)

Created:
6 years, 7 months ago by Yoyo Zhou
Modified:
6 years, 6 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

extensions::Dispatcher: Don't crash if forced_idle_timer_ is null. This can happen if we receive an IdleNotification after OnRenderProcessShutdown. BUG=367711 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277984

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M extensions/renderer/dispatcher.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Yoyo Zhou
6 years, 7 months ago (2014-04-28 18:35:44 UTC) #1
Jeffrey Yasskin
LGTM, with the note that we should really write some dispatcher tests.
6 years, 7 months ago (2014-04-28 18:45:52 UTC) #2
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 7 months ago (2014-04-28 18:50:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/256803012/1
6 years, 7 months ago (2014-04-28 18:51:24 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 20:20:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 20:20:31 UTC) #6
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 6 months ago (2014-06-18 00:48:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/256803012/1
6 years, 6 months ago (2014-06-18 00:49:16 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 01:27:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/18145)
6 years, 6 months ago (2014-06-18 01:27:44 UTC) #10
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 6 months ago (2014-06-18 02:18:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/256803012/20001
6 years, 6 months ago (2014-06-18 02:20:21 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 08:26:27 UTC) #13
Message was sent while issue was closed. 
Change committed as 277984

Powered by Google App Engine
This is Rietveld 408576698