For x64 set android_ndk_lib to /usr/lib64.

For x64 set android_ndk_lib to /usr/lib64.

The latest version of the NDK experimental crtend in this location.
Andrew Hsieh confirms this is correct for multilib NDK.

BUG=346626
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266789

[rmcilroy, 2014-04-28 11:11:25]

Andrew's email said we should include both lib64 and then lib (in that order)
for x86_64 builds.  Do we need to do that here?

https://codereview.chromium.org/256803008/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/256803008/diff/1/build/common.gypi#newcode1524
build/common.gypi:1524: 'android_ndk_lib':
'<(android_ndk_root)/platforms/android-14/arch-x86/usr/lib',
Could you make this "'android_ndk_lib_dir': 'usr/lib(64)'", then in the scope
below have:
 android_ndk_lib: '<(android_ndk_sysroot)/<(android_ndk_lib_dir)'.

This will avoid you having to write /platforms/android-14/arch-x86/, etc. twice
(which would be easy to miss updating one when moving the build to a different
platform.

[Anton, 2014-04-28 11:35:46]

On 2014/04/28 11:11:25, rmcilroy wrote:
> Andrew's email said we should include both lib64 and then lib (in that order)
> for x86_64 builds.  Do we need to do that here?

The path search is already working, the linker finds the correct library using
sysroot except in the case were the exact absolute path is given. 
This change fixes it so that when we give an exact path it is the correct exact
path.

> https://codereview.chromium.org/256803008/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
> https://codereview.chromium.org/256803008/diff/1/build/common.gypi#newcode1524
> build/common.gypi:1524: 'android_ndk_lib':
> '<(android_ndk_root)/platforms/android-14/arch-x86/usr/lib',
> Could you make this "'android_ndk_lib_dir': 'usr/lib(64)'", then in the scope
> below have:
>  android_ndk_lib: '<(android_ndk_sysroot)/<(android_ndk_lib_dir)'.
> 
> This will avoid you having to write /platforms/android-14/arch-x86/, etc.
twice
> (which would be easy to miss updating one when moving the build to a different
> platform.

Done

[rmcilroy, 2014-04-28 11:55:13]

Makes sense.  lgtm (modulo one nit), thanks!

https://codereview.chromium.org/256803008/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/256803008/diff/20001/build/common.gypi#newcod...
build/common.gypi:1575: 'android_ndk_lib':
'<(android_ndk_sysroot)<(android_ndk_lib_dir)',
nit - I would prefer the "/" is here (rather than in "/usr/lib") to show that
this is building a path.

[Anton, 2014-04-28 12:12:43]

On 2014/04/28 11:55:13, rmcilroy wrote:
> Makes sense.  lgtm (modulo one nit), thanks!
> 
> https://codereview.chromium.org/256803008/diff/20001/build/common.gypi
> File build/common.gypi (right):
> 
>
https://codereview.chromium.org/256803008/diff/20001/build/common.gypi#newcod...
> build/common.gypi:1575: 'android_ndk_lib':
> '<(android_ndk_sysroot)<(android_ndk_lib_dir)',
> nit - I would prefer the "/" is here (rather than in "/usr/lib") to show that
> this is building a path.

Done

[rmcilroy, 2014-04-28 12:52:13]

On 2014/04/28 12:12:43, Anton wrote:
> On 2014/04/28 11:55:13, rmcilroy wrote:
> > Makes sense.  lgtm (modulo one nit), thanks!
> > 
> > https://codereview.chromium.org/256803008/diff/20001/build/common.gypi
> > File build/common.gypi (right):
> > 
> >
>
https://codereview.chromium.org/256803008/diff/20001/build/common.gypi#newcod...
> > build/common.gypi:1575: 'android_ndk_lib':
> > '<(android_ndk_sysroot)<(android_ndk_lib_dir)',
> > nit - I would prefer the "/" is here (rather than in "/usr/lib") to show
that
> > this is building a path.
> 
> Done

Thanks, still lgtm.

[Anton, 2014-04-28 17:02:06]

The CQ bit was checked by anton@chromium.org

[commit-bot: I haz the power, 2014-04-28 17:02:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/anton@chromium.org/256803008/60001

[commit-bot: I haz the power, 2014-04-28 19:27:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 19:27:33]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[rmcilroy, 2014-04-29 07:06:55]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2014-04-29 07:07:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/anton@chromium.org/256803008/60001

[commit-bot: I haz the power, 2014-04-29 08:54:20]

Change committed as 266789