Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: components/reading_list/ios/reading_list_store_delegate.h

Issue 2568023002: Fix inheritance in Reading List (Closed)
Patch Set: clean includes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/reading_list/ios/reading_list_store.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/reading_list/ios/reading_list_store_delegate.h
diff --git a/components/reading_list/ios/reading_list_store_delegate.h b/components/reading_list/ios/reading_list_store_delegate.h
index a50e6d6b6782f1f76be2374423e6cfe94de353ba..d95100c353fa16e7cfbf14020782ed9075d01750 100644
--- a/components/reading_list/ios/reading_list_store_delegate.h
+++ b/components/reading_list/ios/reading_list_store_delegate.h
@@ -14,9 +14,6 @@ class ReadingListEntry;
// The delegate to handle callbacks from the ReadingListStore.
class ReadingListStoreDelegate {
public:
- ReadingListStoreDelegate() {}
- virtual ~ReadingListStoreDelegate() {}
-
using ReadingListEntries = std::map<GURL, ReadingListEntry>;
// These three methods handle callbacks from a ReadingListStore.
// This method is called when the local store is loaded. |entries| contains
@@ -36,6 +33,11 @@ class ReadingListStoreDelegate {
// Called to remove an entry to the model.
virtual void SyncRemoveEntry(const GURL& url) = 0;
+
+ protected:
+ ReadingListStoreDelegate() {}
+ virtual ~ReadingListStoreDelegate() {}
+
private:
DISALLOW_COPY_AND_ASSIGN(ReadingListStoreDelegate);
};
« no previous file with comments | « components/reading_list/ios/reading_list_store.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698