Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: components/reading_list/ios/reading_list_model_unittest.mm

Issue 2568023002: Fix inheritance in Reading List (Closed)
Patch Set: clean includes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/reading_list/ios/reading_list_model_unittest.mm
diff --git a/components/reading_list/ios/reading_list_model_unittest.mm b/components/reading_list/ios/reading_list_model_unittest.mm
index dff2d100dd2abd9a5153b2aa510193ab33214787..91953767bbbc670f96494a8b065478f4960eba96 100644
--- a/components/reading_list/ios/reading_list_model_unittest.mm
+++ b/components/reading_list/ios/reading_list_model_unittest.mm
@@ -10,6 +10,7 @@
#include "components/reading_list/ios/reading_list_model_impl.h"
#include "components/reading_list/ios/reading_list_model_storage.h"
#include "components/reading_list/ios/reading_list_store_delegate.h"
+#include "components/sync/model/metadata_change_list.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
@@ -26,7 +27,10 @@ class TestReadingListStorageObserver {
class TestReadingListStorage : public ReadingListModelStorage {
public:
TestReadingListStorage(TestReadingListStorageObserver* observer)
- : entries_(new ReadingListStoreDelegate::ReadingListEntries()),
+ : ReadingListModelStorage(
+ base::Bind(&syncer::ModelTypeChangeProcessor::Create),
+ syncer::READING_LIST),
+ entries_(new ReadingListStoreDelegate::ReadingListEntries()),
observer_(observer) {}
void AddSampleEntries() {
@@ -83,25 +87,62 @@ class TestReadingListStorage : public ReadingListModelStorage {
delegate->StoreLoaded(std::move(entries_));
}
- syncer::ModelTypeSyncBridge* GetModelTypeSyncBridge() override {
- return nullptr;
- }
-
- std::unique_ptr<ScopedBatchUpdate> EnsureBatchCreated() override {
- return std::unique_ptr<ScopedBatchUpdate>();
- }
-
// Saves or updates an entry. If the entry is not yet in the database, it is
// created.
void SaveEntry(const ReadingListEntry& entry) override {
observer_->ReadingListDidSaveEntry();
}
- // Removed an entry from the storage.
+ // Removes an entry from the storage.
void RemoveEntry(const ReadingListEntry& entry) override {
observer_->ReadingListDidRemoveEntry();
}
+ std::unique_ptr<ScopedBatchUpdate> EnsureBatchCreated() override {
+ return std::unique_ptr<ScopedBatchUpdate>();
+ }
+
+ // Syncing is not used in this test class.
+ std::unique_ptr<syncer::MetadataChangeList> CreateMetadataChangeList()
+ override {
+ NOTREACHED();
+ return std::unique_ptr<syncer::MetadataChangeList>();
+ }
+
+ syncer::SyncError MergeSyncData(
+ std::unique_ptr<syncer::MetadataChangeList> metadata_change_list,
+ syncer::EntityDataMap entity_data_map) override {
+ NOTREACHED();
+ return syncer::SyncError();
+ }
+
+ syncer::SyncError ApplySyncChanges(
+ std::unique_ptr<syncer::MetadataChangeList> metadata_change_list,
+ syncer::EntityChangeList entity_changes) override {
+ NOTREACHED();
+ return syncer::SyncError();
+ }
+
+ void GetData(StorageKeyList storage_keys, DataCallback callback) override {
+ NOTREACHED();
+ return;
+ }
+
+ void GetAllData(DataCallback callback) override {
+ NOTREACHED();
+ return;
+ }
+
+ std::string GetClientTag(const syncer::EntityData& entity_data) override {
+ NOTREACHED();
+ return "";
+ }
+
+ std::string GetStorageKey(const syncer::EntityData& entity_data) override {
+ NOTREACHED();
+ return "";
+ }
+
private:
std::unique_ptr<ReadingListStoreDelegate::ReadingListEntries> entries_;
TestReadingListStorageObserver* observer_;
« no previous file with comments | « components/reading_list/ios/reading_list_model_storage.cc ('k') | components/reading_list/ios/reading_list_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698