third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js - Issue 2568013003: DevTools: Fix 'Add new class' placeholder text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

Issue 2568013003: DevTools: Fix 'Add new class' placeholder text (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js b/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

index c996daeec680c7a66390659003f5ab7a3a453964..1b7ac050fb20e7fab258f14d5aa63163cf732947 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

@@ -10,7 +10,8 @@ Elements.ClassesPaneWidget = class extends UI.Widget {

this.element.className = 'styles-element-classes-pane';

var container = this.element.createChild('div', 'title-container');

this._input = container.createChild('div', 'new-class-input monospace');

- this._input.setAttribute('placeholder', Common.UIString('Add new class'));

+ // Placeholder will be shown via CSS ::before by UI.TextPrompt

lushnikov 2016/12/12 23:15:35 nit: let's drop the comment - the code below is de

+ this._input.setAttribute('data-placeholder', Common.UIString('Add new class'));

this.setDefaultFocusedElement(this._input);

this._classesContainer = this.element.createChild('div', 'source-code');

this._classesContainer.classList.add('styles-element-classes-container');

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css » ('j') | no next file with comments »