Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Side by Side Diff: chrome/browser/resources/inspect/inspect.js

Issue 25680003: chrome://inspect: Alignment fix for Android webviews (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var MIN_VERSION_TAB_CLOSE = 25; 5 var MIN_VERSION_TAB_CLOSE = 25;
6 var MIN_VERSION_TARGET_ID = 26; 6 var MIN_VERSION_TARGET_ID = 26;
7 var MIN_VERSION_NEW_TAB = 29; 7 var MIN_VERSION_NEW_TAB = 29;
8 var MIN_VERSION_TAB_ACTIVATE = 30; 8 var MIN_VERSION_TAB_ACTIVATE = 30;
9 9
10 function inspect(data) { 10 function inspect(data) {
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 } 384 }
385 if (webview.attached) { 385 if (webview.attached) {
386 viewStatus.position = 386 viewStatus.position =
387 'at (' + webview.screenX + ', ' + webview.screenY + ')'; 387 'at (' + webview.screenX + ', ' + webview.screenY + ')';
388 } 388 }
389 389
390 var subRow = document.createElement('div'); 390 var subRow = document.createElement('div');
391 subRow.className = 'subrow webview'; 391 subRow.className = 'subrow webview';
392 if (webview.empty || !webview.attached || !webview.visible) 392 if (webview.empty || !webview.attached || !webview.visible)
393 subRow.className += ' invisible-view'; 393 subRow.className += ' invisible-view';
394 subRow.appendChild(formatValue(viewStatus, 'visibility')); 394 if (viewStatus.visibility)
395 subRow.appendChild(formatValue(viewStatus, 'visibility'));
395 subRow.appendChild(formatValue(viewStatus, 'position')); 396 subRow.appendChild(formatValue(viewStatus, 'position'));
396 subRow.appendChild(formatValue(viewStatus, 'size')); 397 subRow.appendChild(formatValue(viewStatus, 'size'));
397 var mainSubrow = row.querySelector('.subrow.main'); 398 var mainSubrow = row.querySelector('.subrow.main');
398 if (mainSubrow.nextSibling) 399 if (mainSubrow.nextSibling)
399 mainSubrow.parentNode.insertBefore(subRow, mainSubrow.nextSibling); 400 mainSubrow.parentNode.insertBefore(subRow, mainSubrow.nextSibling);
400 else 401 else
401 mainSubrow.parentNode.appendChild(subRow); 402 mainSubrow.parentNode.appendChild(subRow);
402 } 403 }
403 404
404 function addWebViewThumbnail(row, webview, screenWidth, screenHeight) { 405 function addWebViewThumbnail(row, webview, screenWidth, screenHeight) {
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
711 if (line.querySelector('.invalid')) 712 if (line.querySelector('.invalid'))
712 return; 713 return;
713 line.classList.remove('fresh'); 714 line.classList.remove('fresh');
714 var freshLine = createEmptyConfigLine(); 715 var freshLine = createEmptyConfigLine();
715 line.parentNode.appendChild(freshLine); 716 line.parentNode.appendChild(freshLine);
716 if (opt_selectNew) 717 if (opt_selectNew)
717 freshLine.querySelector('.port').focus(); 718 freshLine.querySelector('.port').focus();
718 } 719 }
719 720
720 document.addEventListener('DOMContentLoaded', onload); 721 document.addEventListener('DOMContentLoaded', onload);
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698