Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3132)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h

Issue 2567973002: Mac: Fix lifetime problem under BookmarkBarController stopPulsingBookmarkNode. (Closed)
Patch Set: Guarantee a crash Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
index e390147a4202cb44a763b20c3d57f978201b5c25..5f4fe0b93c413f6f1c16b75877ae5f50cdac0da7 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
@@ -294,10 +294,10 @@ willAnimateFromState:(BookmarkBar::State)oldState
base::scoped_nsobject<BookmarkContextMenuCocoaController>
contextMenuController_;
- // Weak pointer to the pulsed button for the currently pulsing node. We need
- // to store this as it may not be possible to determine the pulsing button if
- // the pulsing node is deleted. Nil if there is no pulsing node.
- BookmarkButton* pulsingButton_;
+ // The pulsed button for the currently pulsing node. We need to store this as
+ // it may not be possible to determine the pulsing button if the pulsing node
+ // is deleted. Nil if there is no pulsing node.
+ base::scoped_nsobject<BookmarkButton> pulsingButton_;
// Specifically watch the currently pulsing node. This lets us stop pulsing
// when anything happens to the node. Null if there is no pulsing node.
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698