Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2567963002: Change ComputedStyle::setWritingMode() to return void instead of bool (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index fddd23cd5c63f15b36ce23268a2df0aa29a20196..6fc84d3c5015f73e7c89c387fdda573d84312013 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -2280,13 +2280,7 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
WritingMode getWritingMode() const {
return static_cast<WritingMode>(m_inheritedData.m_writingMode);
}
- bool setWritingMode(WritingMode v) {
- if (v == getWritingMode())
- return false;
-
- m_inheritedData.m_writingMode = v;
- return true;
- }
+ void setWritingMode(WritingMode v) { m_inheritedData.m_writingMode = v; }
// Text emphasis properties.
static TextEmphasisFill initialTextEmphasisFill() {
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698