Change ComputedStyle::setWritingMode() to return void instead of bool

third_party/WebKit/Source/core/css/resolver/StyleResolverState.h

Index: third_party/WebKit/Source/core/css/resolver/StyleResolverState.h
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolverState.h b/third_party/WebKit/Source/core/css/resolver/StyleResolverState.h
index 2518986039a1d40b44d8fedcb001b760a2a8fa48..30d3de29f62e10e3cd2348cc213d1d741d268959 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleResolverState.h
+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolverState.h
@@ -182,9 +182,12 @@ class CORE_EXPORT StyleResolverState {
     if (m_style->setEffectiveZoom(f))
       m_fontBuilder.didChangeEffectiveZoom();
   }
-  void setWritingMode(WritingMode writingMode) {
-    if (m_style->setWritingMode(writingMode))
-      m_fontBuilder.didChangeWritingMode();
+  void setWritingMode(WritingMode newWritingMode) {
+    const WritingMode oldWritingMode = m_style->getWritingMode();

[napper, 2016/12/12 03:53:33]

Not sure you need the temporary here.

[sashab, 2016/12/12 03:58:39]

Sure, thought it helped with readability. Kept the other one called
'newWritingMode' to make it clear.

+    if (oldWritingMode == newWritingMode)

[napper, 2016/12/12 03:53:33]

FWIW I have a style preference for either:

if (oldWritingMode == newWritingMode) return;

- or -

if (oldWritingMode == newWritingMode) {
  return;
}

since I have seen many examples of the following bug:

if (oldWritingMode == newWritingMode)
  <added line here>
  return;

[sashab, 2016/12/12 03:58:39]

Ack, that's a really good point!! I actually thought our style checker presubmit
would reject these brackets since the statement is only one line, but it didn't
:) Will get alancutter@s opinion too.

+      return;
+    m_style->setWritingMode(newWritingMode);
+    m_fontBuilder.didChangeWritingMode();
   }
   void setTextOrientation(TextOrientation textOrientation) {
     if (m_style->setTextOrientation(textOrientation))