Change ComputedStyle::setWritingMode() to return void instead of bool

third_party/WebKit/Source/core/layout/LayoutObject.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc.
  *               All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  *               (http://www.torchmobile.com/)
@@ skipping 1935 matching lines @@
   setStyle(std::move(style));
 }
 
 void LayoutObject::setStyleWithWritingModeOfParent(
     PassRefPtr<ComputedStyle> style) {
   setStyleWithWritingModeOf(std::move(style), parent());
 }
 
 void LayoutObject::addChildWithWritingModeOfParent(LayoutObject* newChild,
                                                    LayoutObject* beforeChild) {
-  if (newChild->mutableStyleRef().setWritingMode(styleRef().getWritingMode()) &&
-      newChild->isBoxModelObject()) {
+  const WritingMode oldWritingMode =
+      newChild->mutableStyleRef().getWritingMode();
+  const WritingMode newWritingMode = styleRef().getWritingMode();
+  if (oldWritingMode != newWritingMode && newChild->isBoxModelObject()) {
+    newChild->mutableStyleRef().setWritingMode(newWritingMode);
     newChild->setHorizontalWritingMode(isHorizontalWritingMode());
   }
   addChild(newChild, beforeChild);
 }
 
 void LayoutObject::updateFillImages(const FillLayer* oldLayers,
                                     const FillLayer& newLayers) {
   // Optimize the common case
   if (FillLayer::imagesIdentical(oldLayers, &newLayers))
     return;
@@ skipping 1540 matching lines @@
     const blink::LayoutObject* root = object1;
     while (root->parent())
       root = root->parent();
     root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
   } else {
     WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)");
   }
 }
 
 #endif