Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2567963002: Change ComputedStyle::setWritingMode() to return void instead of bool (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
6 * rights reserved. 6 * rights reserved.
7 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 2264 matching lines...) Expand 10 before | Expand all | Expand 10 after
2275 LineBreak getLineBreak() const { 2275 LineBreak getLineBreak() const {
2276 return static_cast<LineBreak>(m_rareInheritedData->lineBreak); 2276 return static_cast<LineBreak>(m_rareInheritedData->lineBreak);
2277 } 2277 }
2278 void setLineBreak(LineBreak b) { SET_VAR(m_rareInheritedData, lineBreak, b); } 2278 void setLineBreak(LineBreak b) { SET_VAR(m_rareInheritedData, lineBreak, b); }
2279 2279
2280 // writing-mode (aka -webkit-writing-mode, -epub-writing-mode) 2280 // writing-mode (aka -webkit-writing-mode, -epub-writing-mode)
2281 static WritingMode initialWritingMode() { return TopToBottomWritingMode; } 2281 static WritingMode initialWritingMode() { return TopToBottomWritingMode; }
2282 WritingMode getWritingMode() const { 2282 WritingMode getWritingMode() const {
2283 return static_cast<WritingMode>(m_inheritedData.m_writingMode); 2283 return static_cast<WritingMode>(m_inheritedData.m_writingMode);
2284 } 2284 }
2285 bool setWritingMode(WritingMode v) { 2285 void setWritingMode(WritingMode v) { m_inheritedData.m_writingMode = v; }
2286 if (v == getWritingMode())
2287 return false;
2288
2289 m_inheritedData.m_writingMode = v;
2290 return true;
2291 }
2292 2286
2293 // Text emphasis properties. 2287 // Text emphasis properties.
2294 static TextEmphasisFill initialTextEmphasisFill() { 2288 static TextEmphasisFill initialTextEmphasisFill() {
2295 return TextEmphasisFillFilled; 2289 return TextEmphasisFillFilled;
2296 } 2290 }
2297 static TextEmphasisMark initialTextEmphasisMark() { 2291 static TextEmphasisMark initialTextEmphasisMark() {
2298 return TextEmphasisMarkNone; 2292 return TextEmphasisMarkNone;
2299 } 2293 }
2300 static const AtomicString& initialTextEmphasisCustomMark() { 2294 static const AtomicString& initialTextEmphasisCustomMark() {
2301 return nullAtom; 2295 return nullAtom;
(...skipping 1774 matching lines...) Expand 10 before | Expand all | Expand 10 after
4076 m_nonInheritedData.m_pseudoBits |= 1 << (pseudo - 1); 4070 m_nonInheritedData.m_pseudoBits |= 1 << (pseudo - 1);
4077 } 4071 }
4078 4072
4079 inline bool ComputedStyle::hasPseudoElementStyle() const { 4073 inline bool ComputedStyle::hasPseudoElementStyle() const {
4080 return m_nonInheritedData.m_pseudoBits & ElementPseudoIdMask; 4074 return m_nonInheritedData.m_pseudoBits & ElementPseudoIdMask;
4081 } 4075 }
4082 4076
4083 } // namespace blink 4077 } // namespace blink
4084 4078
4085 #endif // ComputedStyle_h 4079 #endif // ComputedStyle_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698