Change ComputedStyle::setWritingMode() to return void instead of bool

third_party/WebKit/Source/core/css/resolver/StyleResolverState.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc.
  * All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 164 matching lines @@
   }
 
   void setZoom(float f) {
     if (m_style->setZoom(f))
       m_fontBuilder.didChangeEffectiveZoom();
   }
   void setEffectiveZoom(float f) {
     if (m_style->setEffectiveZoom(f))
       m_fontBuilder.didChangeEffectiveZoom();
   }
-  void setWritingMode(WritingMode writingMode) {
-    if (m_style->setWritingMode(writingMode))
+  void setWritingMode(WritingMode newWritingMode) {
+    const WritingMode oldWritingMode = m_style->getWritingMode();
+    if (oldWritingMode != newWritingMode) {

[sashab, 2016/12/12 02:26:17]

For no reason whatsoever, changed this to be an early return. It's a little
prettier maybe? ^_^

+      m_style->setWritingMode(newWritingMode);
       m_fontBuilder.didChangeWritingMode();
+    }
   }
   void setTextOrientation(TextOrientation textOrientation) {
     if (m_style->setTextOrientation(textOrientation))
       m_fontBuilder.didChangeTextOrientation();
   }
 
   void setHasDirAutoAttribute(bool value) { m_hasDirAutoAttribute = value; }
   bool hasDirAutoAttribute() const { return m_hasDirAutoAttribute; }
 
   void setCustomPropertySetForApplyAtRule(const String&, StylePropertySet*);
@@ skipping 35 matching lines @@
 
   mutable HeapHashMap<
       Member<const CSSPendingSubstitutionValue>,
       Member<HeapHashMap<CSSPropertyID, Member<const CSSValue>>>>
       m_parsedPropertiesForPendingSubstitutionCache;
 };
 
 }  // namespace blink
 
 #endif  // StyleResolverState_h