Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2567943003: Remove support for mixin typedefs in dart2js. (Closed)

Created:
4 years ago by floitsch
Modified:
4 years ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -56 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 3 chunks +1 line, -15 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 3 chunks +9 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
floitsch
4 years ago (2016-12-12 17:20:17 UTC) #2
Siggi Cherem (dart-lang)
lgtm! +ahe: FYI - you may want to keep in sync with this small change ...
4 years ago (2016-12-12 17:25:04 UTC) #4
ahe
On 2016/12/12 17:25:04, Siggi Cherem (dart-lang) wrote: > lgtm! > > +ahe: FYI - you ...
4 years ago (2016-12-12 20:00:06 UTC) #5
Johnni Winther
lgtm
4 years ago (2016-12-13 09:14:34 UTC) #6
floitsch
4 years ago (2016-12-13 13:04:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7374ec71bd52a23a6dbe074f208c0a1a7a3bdd79 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698