Issue 256793003: Temporarily disable the gn v8_base target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 256793003: Temporarily disable the gn v8_base target (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Temporarily disable the gn v8_base target We'll have to figure out a way to maintain this file without blocking v8 rolls. While the gyp files in v8 don't change very often, they sometimes do, and since the CQ checks the gn build, we have to find a way to update gn in lock step BUG=none TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266533

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+664 lines, -662 lines)			Patch
	M	tools/gn/secondary/v8/BUILD.gn	View		2 chunks	+664 lines, -662 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

6 years, 7 months ago (2014-04-28 13:04:13 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r266533 (tree was closed).

Expand Messages | Collapse Messages