Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3111)

Unified Diff: device/bluetooth/bluetooth_low_energy_win_fake.cc

Issue 2567903004: Replace ScopedVector/ScopedPtrHashMap with std::vector and std::unordered_map (Closed)
Patch Set: Mac bustage Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_low_energy_win_fake.cc
diff --git a/device/bluetooth/bluetooth_low_energy_win_fake.cc b/device/bluetooth/bluetooth_low_energy_win_fake.cc
index d6f64df63f5ede14b8a19462c8a6015bffbb0786..e5bf85ae2efed4d994ba3df96c51a023e853df8b 100644
--- a/device/bluetooth/bluetooth_low_energy_win_fake.cc
+++ b/device/bluetooth/bluetooth_low_energy_win_fake.cc
@@ -42,7 +42,7 @@ bool BluetoothLowEnergyWrapperFake::IsBluetoothLowEnergySupported() {
}
bool BluetoothLowEnergyWrapperFake::EnumerateKnownBluetoothLowEnergyDevices(
- ScopedVector<BluetoothLowEnergyDeviceInfo>* devices,
+ std::vector<std::unique_ptr<BluetoothLowEnergyDeviceInfo>>* devices,
std::string* error) {
if (!IsBluetoothLowEnergySupported()) {
*error = kPlatformNotSupported;
@@ -52,17 +52,16 @@ bool BluetoothLowEnergyWrapperFake::EnumerateKnownBluetoothLowEnergyDevices(
for (auto& device : simulated_devices_) {
if (device.second->marked_as_deleted)
continue;
- BluetoothLowEnergyDeviceInfo* device_info =
- new BluetoothLowEnergyDeviceInfo();
+ auto device_info = base::MakeUnique<BluetoothLowEnergyDeviceInfo>();
*device_info = *(device.second->device_info);
- devices->push_back(device_info);
+ devices->push_back(std::move(device_info));
}
return true;
}
bool BluetoothLowEnergyWrapperFake::
EnumerateKnownBluetoothLowEnergyGattServiceDevices(
- ScopedVector<BluetoothLowEnergyDeviceInfo>* devices,
+ std::vector<std::unique_ptr<BluetoothLowEnergyDeviceInfo>>* devices,
std::string* error) {
if (!IsBluetoothLowEnergySupported()) {
*error = kPlatformNotSupported;
@@ -71,14 +70,13 @@ bool BluetoothLowEnergyWrapperFake::
for (auto& device : simulated_devices_) {
for (auto& service : device.second->primary_services) {
- BluetoothLowEnergyDeviceInfo* device_info =
- new BluetoothLowEnergyDeviceInfo();
+ auto device_info = base::MakeUnique<BluetoothLowEnergyDeviceInfo>();
*device_info = *(device.second->device_info);
base::string16 path = GenerateGattServiceDevicePath(
device.second->device_info->path.value(),
service.second->service_info->AttributeHandle);
device_info->path = base::FilePath(path);
- devices->push_back(device_info);
+ devices->push_back(std::move(device_info));
}
}
return true;
@@ -86,7 +84,7 @@ bool BluetoothLowEnergyWrapperFake::
bool BluetoothLowEnergyWrapperFake::EnumerateKnownBluetoothLowEnergyServices(
const base::FilePath& device_path,
- ScopedVector<BluetoothLowEnergyServiceInfo>* services,
+ std::vector<std::unique_ptr<BluetoothLowEnergyServiceInfo>>* services,
std::string* error) {
if (!IsBluetoothLowEnergySupported()) {
*error = kPlatformNotSupported;
@@ -107,23 +105,21 @@ bool BluetoothLowEnergyWrapperFake::EnumerateKnownBluetoothLowEnergyServices(
if (service_attribute_handles.empty()) {
// Return all primary services for BLE device.
for (auto& primary_service : it_d->second->primary_services) {
- BluetoothLowEnergyServiceInfo* service_info =
- new BluetoothLowEnergyServiceInfo();
+ auto service_info = base::MakeUnique<BluetoothLowEnergyServiceInfo>();
service_info->uuid = primary_service.second->service_info->ServiceUuid;
service_info->attribute_handle =
primary_service.second->service_info->AttributeHandle;
- services->push_back(service_info);
+ services->push_back(std::move(service_info));
}
} else {
// Return corresponding GATT service for BLE GATT service device.
GattService* target_service =
GetSimulatedGattService(it_d->second.get(), service_attribute_handles);
- BluetoothLowEnergyServiceInfo* service_info =
- new BluetoothLowEnergyServiceInfo();
+ auto service_info = base::MakeUnique<BluetoothLowEnergyServiceInfo>();
service_info->uuid = target_service->service_info->ServiceUuid;
service_info->attribute_handle =
target_service->service_info->AttributeHandle;
- services->push_back(service_info);
+ services->push_back(std::move(service_info));
}
return true;
@@ -523,7 +519,7 @@ void BluetoothLowEnergyWrapperFake::SimulateGattDescriptor(
std::string device_address,
GattCharacteristic* characteristic,
const BTH_LE_UUID& uuid) {
- std::unique_ptr<GattDescriptor> descriptor(new GattDescriptor());
+ auto descriptor = base::MakeUnique<GattDescriptor>();
descriptor->descriptor_info.reset(new BTH_LE_GATT_DESCRIPTOR[1]);
descriptor->descriptor_info->DescriptorUuid = uuid;
descriptor->descriptor_info->AttributeHandle =

Powered by Google App Engine
This is Rietveld 408576698