Replace ScopedVector/ScopedPtrHashMap with std::vector and std::unordered_map

device/bluetooth/bluetooth_device_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_device_android.h"
 
 #include "base/android/context_utils.h"
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 228 matching lines @@
 
 void BluetoothDeviceAndroid::CreateGattRemoteService(
     JNIEnv* env,
     const JavaParamRef<jobject>& caller,
     const JavaParamRef<jstring>& instance_id,
     const JavaParamRef<jobject>&
         bluetooth_gatt_service_wrapper) {  // BluetoothGattServiceWrapper
   std::string instance_id_string =
       base::android::ConvertJavaStringToUTF8(env, instance_id);
 
-  if (gatt_services_.contains(instance_id_string))
+  if (gatt_services_.find(instance_id_string) != gatt_services_.end())

[Reilly Grant (use Gerrit), 2016/12/21 22:25:13]

if (base::ContainsKey(gatt_services_, instance_id_string))

[dougt, 2016/12/22 01:18:02]

Done.

     return;
 
-  BluetoothDevice::GattServiceMap::iterator service_iterator =
-      gatt_services_.set(
-          instance_id_string,
-          BluetoothRemoteGattServiceAndroid::Create(
-              GetAndroidAdapter(), this, bluetooth_gatt_service_wrapper,
-              instance_id_string, j_device_));
+  auto service = BluetoothRemoteGattServiceAndroid::Create(
+      GetAndroidAdapter(), this, bluetooth_gatt_service_wrapper,
+      instance_id_string, j_device_);
 
-  adapter_->NotifyGattServiceAdded(service_iterator->second);
+  auto insertion = gatt_services_.insert(
+      std::make_pair(instance_id_string, std::move(service)));
+  if (insertion.second == false) {

[Reilly Grant (use Gerrit), 2016/12/21 22:25:14]

insertion.second will always be true because we check that instance_id_string
isn't in gatt_services_ at the top of this function. Use the subscript operator
to insert into gatt_services_.

[dougt, 2016/12/22 01:18:02]

Done.

+    return;
+  }
+  adapter_->NotifyGattServiceAdded(insertion.first->second.get());
 }
 
 BluetoothDeviceAndroid::BluetoothDeviceAndroid(BluetoothAdapterAndroid* adapter)
     : BluetoothDevice(adapter) {}
 
 void BluetoothDeviceAndroid::CreateGattConnectionImpl() {
   Java_ChromeBluetoothDevice_createGattConnectionImpl(
       AttachCurrentThread(), j_device_, base::android::GetApplicationContext());
 }
 
 void BluetoothDeviceAndroid::DisconnectGatt() {
   Java_ChromeBluetoothDevice_disconnectGatt(AttachCurrentThread(), j_device_);
 }
 
 }  // namespace device