Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: components/exo/keyboard.cc

Issue 2567903003: exo: Produce an error if get_keyboard_device_configuration is called with a keyboard object that al… (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/exo/keyboard.cc
diff --git a/components/exo/keyboard.cc b/components/exo/keyboard.cc
index 206b61f72c5b4c9ac404989b32f272b4e29ec126..cadf270586f6ada2895394aad91ce118ef94ca11 100644
--- a/components/exo/keyboard.cc
+++ b/components/exo/keyboard.cc
@@ -114,6 +114,10 @@ Keyboard::~Keyboard() {
helper->RemoveInputDeviceEventObserver(this);
}
+bool Keyboard::HasDeviceConfigurationDelegate() const {
+ return device_configuration_delegate_ != nullptr;
reveman 2016/12/12 11:52:56 nit: !!device_configuration_delegate_ is preferred
yhanada 2016/12/12 15:44:03 Thanks for pointing it out. Done.
+}
+
void Keyboard::SetDeviceConfigurationDelegate(
KeyboardDeviceConfigurationDelegate* delegate) {
device_configuration_delegate_ = delegate;

Powered by Google App Engine
This is Rietveld 408576698