Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: net/http/http_server_properties_manager.h

Issue 2567893002: Pass pref_task_runner through HttpServerPropertiesManager's cxtor so that tests could inject a Test… (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_server_properties_manager.h
diff --git a/net/http/http_server_properties_manager.h b/net/http/http_server_properties_manager.h
index e1c47ff913daa3d72a5e848cc3e17f88dc215d68..15fb05335aa7ea3c4dbb49d2798c79a966833797 100644
--- a/net/http/http_server_properties_manager.h
+++ b/net/http/http_server_properties_manager.h
@@ -84,6 +84,7 @@ class NET_EXPORT HttpServerPropertiesManager : public HttpServerProperties {
// Must be constructed on the Pref thread.
brettw 2016/12/13 23:26:13 Can you add a description here of the two task run
Zhongyi Shi 2016/12/14 19:47:24 Sorry about the confusion. I have updated the CL d
brettw 2016/12/14 23:16:54 Thanks for the description update. But I think we
Zhongyi Shi 2016/12/14 23:36:58 Oh, sorry that I miss the comments in the headers
HttpServerPropertiesManager(
PrefDelegate* pref_delegate,
+ scoped_refptr<base::SingleThreadTaskRunner> pref_task_runner,
scoped_refptr<base::SingleThreadTaskRunner> network_task_runner);
~HttpServerPropertiesManager() override;

Powered by Google App Engine
This is Rietveld 408576698