DevTools: Add ability to add and edit cookies

third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js

Index: third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js b/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
index 49d49e9a311c38e7940e6ab2ebbf303bdff9c828..6230b58f4313a768291b014b716f247f66f89636 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
@@ -310,6 +310,18 @@ UI.DataGrid = class extends Common.Object {
   }
 
   /**
+   * @param {!UI.DataGridNode} node
+   * @param {string} columnIdentifier
+   */
+  startEditingNextEditableColumnOfDataGridNode(node, columnIdentifier) {
+    const column = this._columns[columnIdentifier];
+    const cellIndex = this._visibleColumnsArray.indexOf(column);
+    const nextEditableColumn = this._nextEditableColumn(cellIndex);
+    if (nextEditableColumn !== -1)
+      this._startEditingColumnOfDataGridNode(node, nextEditableColumn);
+  }
+
+  /**
    * @param {!Node} target
    */
   _startEditing(target) {
@@ -367,7 +379,7 @@ UI.DataGrid = class extends Common.Object {
     }
     var column = this._columns[columnId];
     var cellIndex = this._visibleColumnsArray.indexOf(column);
-    var textBeforeEditing = /** @type {string} */ (this._editingNode.data[columnId]);
+    var textBeforeEditing = /** @type {string} */ (this._editingNode.data[columnId] || '');
     var currentEditingNode = this._editingNode;
 
     /**
@@ -1215,6 +1227,8 @@ UI.DataGridNode = class extends Common.Object {
     this._expanded = false;
     /** @type {boolean} */
     this._selected = false;
+    /** @type {boolean} */
+    this._dirty = false;
     /** @type {number|undefined} */
     this._depth;
     /** @type {boolean|undefined} */
@@ -1276,6 +1290,8 @@ UI.DataGridNode = class extends Common.Object {
       this._element.classList.add('selected');
     if (this.revealed)
       this._element.classList.add('revealed');
+    if (this.dirty)
+      this._element.classList.add('dirty');
     return this._element;
   }
 
@@ -1360,6 +1376,26 @@ UI.DataGridNode = class extends Common.Object {
   /**
    * @return {boolean}
    */
+  isDirty() {
+    return this._dirty;
+  }
+
+  /**
+   * @param {boolean} x
+   */
+  setDirty(x) {

[allada, 2016/12/23 00:37:11]

nit: We are trying not to do this anymore and name all parameters.

Can we change "x" to "dirty"?

+    this._dirty = x;

[allada, 2016/12/23 00:37:11]

nit: We usually check if we need to change the value then set it if we do. eg:

if (this._dirty === dirty)
  return;
this._dirty = dirty;

+    if (!this._element)
+      return;
+    if (x)
+      this._element.classList.add('dirty');
+    else
+      this._element.classList.remove('dirty');
+  }
+
+  /**
+   * @return {boolean}
+   */
   hasChildren() {
     return this._hasChildren;
   }