Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp

Issue 2567733002: replace flaky DCHECK in DrawingBuffer with early-out (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/gpu/gpu_tests/webgl_conformance_expectations.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
index 5ac50c4acb226cae15258341c1da6907b007fa0c..1ee06eaa4f2d596e3f6552850e0dc7bc7112c810 100644
--- a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
+++ b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
@@ -713,7 +713,10 @@ bool DrawingBuffer::copyToPlatformTexture(gpu::gles2::GLES2Interface* gl,
m_gl->GenSyncTokenCHROMIUM(fenceSync, produceSyncToken.GetData());
}
- DCHECK(produceSyncToken.HasData());
+ if (!produceSyncToken.HasData()) {
Ken Russell (switch to Gerrit) 2016/12/09 21:23:49 Please add a comment that this should really only
+ return false;
+ }
+
gl->WaitSyncTokenCHROMIUM(produceSyncToken.GetConstData());
GLuint sourceTexture =
gl->CreateAndConsumeTextureCHROMIUM(target, mailbox.name);
« no previous file with comments | « content/test/gpu/gpu_tests/webgl_conformance_expectations.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698