Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 256773005: drive: Handle ApplyEntryMap correctly (Closed)

Created:
6 years, 7 months ago by hashimoto
Modified:
6 years, 7 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

drive: Handle ApplyEntryMap errors correctly We should not update the local changestamp when something goes wrong. BUG=255333 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266576

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M chrome/browser/chromeos/drive/change_list_processor.cc View 1 2 chunks +20 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hashimoto
6 years, 7 months ago (2014-04-28 04:29:46 UTC) #1
kinaba
lgtm https://codereview.chromium.org/256773005/diff/1/chrome/browser/chromeos/drive/change_list_processor.cc File chrome/browser/chromeos/drive/change_list_processor.cc (right): https://codereview.chromium.org/256773005/diff/1/chrome/browser/chromeos/drive/change_list_processor.cc#newcode287 chrome/browser/chromeos/drive/change_list_processor.cc:287: // TODO(hashimoto): Handle ApplyEntry errors correctly. nit: Do ...
6 years, 7 months ago (2014-04-28 08:28:51 UTC) #2
hashimoto
https://codereview.chromium.org/256773005/diff/1/chrome/browser/chromeos/drive/change_list_processor.cc File chrome/browser/chromeos/drive/change_list_processor.cc (right): https://codereview.chromium.org/256773005/diff/1/chrome/browser/chromeos/drive/change_list_processor.cc#newcode287 chrome/browser/chromeos/drive/change_list_processor.cc:287: // TODO(hashimoto): Handle ApplyEntry errors correctly. On 2014/04/28 08:28:52, ...
6 years, 7 months ago (2014-04-28 09:30:54 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 7 months ago (2014-04-28 09:30:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/256773005/20001
6 years, 7 months ago (2014-04-28 09:31:47 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 10:22:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 7 months ago (2014-04-28 10:22:35 UTC) #7
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 7 months ago (2014-04-28 11:21:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/256773005/20001
6 years, 7 months ago (2014-04-28 11:22:40 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 15:41:59 UTC) #10
Message was sent while issue was closed. 
Change committed as 266576

Powered by Google App Engine
This is Rietveld 408576698