Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 256773004: Convert qname with prefix to upper-case in tagName (Closed)

Created:
6 years, 8 months ago by rwlbuis
Modified:
6 years, 8 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, krit, sof, eae+blinkwatch, fs, kouhei+svg_chromium.org, dglazkov+blink, f(malita), adamk+blink_chromium.org, gyuyoung.kim_webkit.org, Inactive, Stephen Chennney, ojan, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Convert qname with prefix to upper-case in tagName if the context object is in the HTML namespace and its node document is as well: http://dom.spec.whatwg.org/#dom-element-tagname This behavior matches Firefox and IE11. TEST=fast/dom/Node/initial-values.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172711

Patch Set 1 #

Patch Set 2 : Strip unwanted parts #

Patch Set 3 : Fix test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M LayoutTests/fast/dom/Node/initial-values-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Node/script-tests/initial-values.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 2 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rwlbuis
PTAL.
6 years, 8 months ago (2014-04-26 23:56:26 UTC) #1
eseidel
And IE?
6 years, 8 months ago (2014-04-27 05:51:10 UTC) #2
rwlbuis
On 2014/04/27 05:51:10, eseidel wrote: > And IE? I checked just now, matched behavior of ...
6 years, 8 months ago (2014-04-27 10:59:47 UTC) #3
eseidel
lgtm
6 years, 8 months ago (2014-04-27 16:55:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/256773004/40001
6 years, 8 months ago (2014-04-27 16:56:15 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-27 18:04:41 UTC) #6
Message was sent while issue was closed.
Change committed as 172711

Powered by Google App Engine
This is Rietveld 408576698