Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 256773003: Change get_child_as_raw_ptr to get_layer_as_raw_ptr (Closed)

Created:
6 years, 8 months ago by Ian Vollick
Modified:
6 years, 7 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Change get_child_as_raw_ptr to get_layer_as_raw_ptr It's semantically more correct. R=danakj@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M cc/layers/layer_iterator.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_common.h View 3 chunks +9 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ian Vollick
Here's the rename patch.
6 years, 8 months ago (2014-04-25 23:26:39 UTC) #1
danakj
LGTM
6 years, 7 months ago (2014-04-28 15:11:24 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-04-28 15:11:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/256773003/1
6 years, 7 months ago (2014-04-28 15:12:08 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 15:13:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 7 months ago (2014-04-28 15:13:59 UTC) #6
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-04-28 15:14:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/256773003/1
6 years, 7 months ago (2014-04-28 15:14:46 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 18:11:30 UTC) #9
Message was sent while issue was closed. 
Change committed as 266606

Powered by Google App Engine
This is Rietveld 408576698