Issue 25677004: Correct and simplify the cookie events browser test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25677004: Correct and simplify the cookie events browser test (Closed)

Created:
7 years, 2 months ago by philipj_slow

Modified:
7 years, 2 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr

Visibility:
Public.

More Reviews

Description

Correct and simplify the cookie events browser test The listeners were being removed in the completion callback to chrome.cookies.set instead of in the chrome.cookiesonChanged listener. Nothing guaranteed the order of these two, so the test begun failing when delete started waiting for flush in <https://chromiumcodereview.appspot.com/18032002>;. Simplify the tests by using listenOnce/listenForever. BUG=302914 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226456

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -52 lines)			Patch
	M	chrome/test/data/extensions/api_test/cookies/events/test.js	View		1 chunk	+29 lines, -52 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/25677004/1

7 years, 2 months ago (2013-10-02 09:00:15 UTC) #3

Message was sent while issue was closed.

Change committed as 226456

Expand Messages | Collapse Messages