Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: chrome/browser/resources/options/password_manager_list.js

Issue 2567693002: Elide origins for passwords settings in CSS instead of JS (Closed)
Patch Set: Add a note about direction Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/options/password_manager_list.css ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options.passwordManager', function() { 5 cr.define('options.passwordManager', function() {
6 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel; 6 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
7 /** @const */ var DeletableItemList = options.DeletableItemList; 7 /** @const */ var DeletableItemList = options.DeletableItemList;
8 /** @const */ var DeletableItem = options.DeletableItem; 8 /** @const */ var DeletableItem = options.DeletableItem;
9 /** @const */ var List = cr.ui.List; 9 /** @const */ var List = cr.ui.List;
10 10
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 * @param {Element} urlDiv div-element that will enclose the created 69 * @param {Element} urlDiv div-element that will enclose the created
70 * element. 70 * element.
71 * @return {Element} The element for displaying the link to the origin. 71 * @return {Element} The element for displaying the link to the origin.
72 */ 72 */
73 function createUrlLink(item, urlDiv) { 73 function createUrlLink(item, urlDiv) {
74 var urlLink; 74 var urlLink;
75 if (item.isClickable) { 75 if (item.isClickable) {
76 urlLink = item.ownerDocument.createElement('a'); 76 urlLink = item.ownerDocument.createElement('a');
77 urlLink.href = item.url; 77 urlLink.href = item.url;
78 urlLink.setAttribute('target', '_blank'); 78 urlLink.setAttribute('target', '_blank');
79 urlLink.dir = 'ltr';
80 } else { 79 } else {
81 urlLink = item.ownerDocument.createElement('span'); 80 urlLink = item.ownerDocument.createElement('span');
82 } 81 }
83 urlLink.textContent = item.shownOrigin; 82 urlLink.textContent = item.shownOrigin;
84 urlLink.addEventListener('focus', function() { 83 urlLink.addEventListener('focus', function() {
85 item.handleFocus(); 84 item.handleFocus();
86 }.bind(item)); 85 }.bind(item));
87 return urlLink; 86 return urlLink;
88 } 87 }
89 88
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
544 SHOWN_ORIGIN_FIELD: SHOWN_ORIGIN_FIELD, 543 SHOWN_ORIGIN_FIELD: SHOWN_ORIGIN_FIELD,
545 IS_ANDROID_URI_FIELD: IS_ANDROID_URI_FIELD, 544 IS_ANDROID_URI_FIELD: IS_ANDROID_URI_FIELD,
546 IS_CLICKABLE_FIELD: IS_CLICKABLE_FIELD, 545 IS_CLICKABLE_FIELD: IS_CLICKABLE_FIELD,
547 IS_SECURE_FIELD: IS_SECURE_FIELD, 546 IS_SECURE_FIELD: IS_SECURE_FIELD,
548 USERNAME_FIELD: USERNAME_FIELD, 547 USERNAME_FIELD: USERNAME_FIELD,
549 PASSWORD_FIELD: PASSWORD_FIELD, 548 PASSWORD_FIELD: PASSWORD_FIELD,
550 FEDERATION_FIELD: FEDERATION_FIELD, 549 FEDERATION_FIELD: FEDERATION_FIELD,
551 ORIGINAL_INDEX_FIELD: ORIGINAL_INDEX_FIELD 550 ORIGINAL_INDEX_FIELD: ORIGINAL_INDEX_FIELD
552 }; 551 };
553 }); 552 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/password_manager_list.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698