chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java - Issue 2567673002: Factor getCertificateChain out of ConnectionPopupInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java

Issue 2567673002: Factor getCertificateChain out of ConnectionPopupInfo (Closed)

Patch Set: Address review comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/pageinfo/CertificateChainHelper.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java

index b99c9289cf39f4ef698b1414c2e7c99c304d2893..8f9d8b799c03fad2eb76f3c7424c3a0244e38a57 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/ConnectionInfoPopup.java

@@ -207,7 +207,7 @@ public class ConnectionInfoPopup implements OnClickListener {

nativeResetCertDecisions(mNativeConnectionInfoPopup, mWebContents);

mDialog.dismiss();

} else if (mCertificateViewer == v) {

- byte[][] certChain = nativeGetCertificateChain(mWebContents);

+ byte[][] certChain = CertificateChainHelper.getCertificateChain(mWebContents);

if (certChain == null) {

// The WebContents may have been destroyed/invalidated. If so,

// ignore this request.

@@ -247,5 +247,4 @@ public class ConnectionInfoPopup implements OnClickListener {

private native void nativeDestroy(long nativeConnectionInfoPopupAndroid);

private native void nativeResetCertDecisions(

long nativeConnectionInfoPopupAndroid, WebContents webContents);

- private native byte[][] nativeGetCertificateChain(WebContents webContents);

}