Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js

Issue 2567573002: DevTools: fix private field usage violation discovered after the compiler roll. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** @typedef {!{ 4 /** @typedef {!{
5 bounds: {height: number, width: number}, 5 bounds: {height: number, width: number},
6 children: Array.<!TimelineModel.TracingLayerPayload>, 6 children: Array.<!TimelineModel.TracingLayerPayload>,
7 layer_id: number, 7 layer_id: number,
8 position: Array.<number>, 8 position: Array.<number>,
9 scroll_offset: Array.<number>, 9 scroll_offset: Array.<number>,
10 layer_quad: Array.<number>, 10 layer_quad: Array.<number>,
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 setLayers(root, layers, paints, callback) { 48 setLayers(root, layers, paints, callback) {
49 var idsToResolve = new Set(); 49 var idsToResolve = new Set();
50 if (root) { 50 if (root) {
51 // This is a legacy code path for compatibility, as cc is removing 51 // This is a legacy code path for compatibility, as cc is removing
52 // layer tree hierarchy, this code will eventually be removed. 52 // layer tree hierarchy, this code will eventually be removed.
53 this._extractNodeIdsToResolve(idsToResolve, {}, root); 53 this._extractNodeIdsToResolve(idsToResolve, {}, root);
54 } else { 54 } else {
55 for (var i = 0; i < layers.length; ++i) 55 for (var i = 0; i < layers.length; ++i)
56 this._extractNodeIdsToResolve(idsToResolve, {}, layers[i]); 56 this._extractNodeIdsToResolve(idsToResolve, {}, layers[i]);
57 } 57 }
58 this._resolveBackendNodeIds(idsToResolve, onBackendNodeIdsResolved.bind(this )); 58 this.resolveBackendNodeIds(idsToResolve, onBackendNodeIdsResolved.bind(this) );
59 59
60 /** 60 /**
61 * @this {TimelineModel.TracingLayerTree} 61 * @this {TimelineModel.TracingLayerTree}
62 */ 62 */
63 function onBackendNodeIdsResolved() { 63 function onBackendNodeIdsResolved() {
64 var oldLayersById = this._layersById; 64 var oldLayersById = this._layersById;
65 this._layersById = {}; 65 this._layersById = {};
66 this.setContentRoot(null); 66 this.setContentRoot(null);
67 if (root) { 67 if (root) {
68 var convertedLayers = this._innerSetLayers(oldLayersById, root); 68 var convertedLayers = this._innerSetLayers(oldLayersById, root);
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 * @return {!TimelineModel.TracingLayer} 125 * @return {!TimelineModel.TracingLayer}
126 */ 126 */
127 _innerSetLayers(oldLayersById, payload) { 127 _innerSetLayers(oldLayersById, payload) {
128 var layer = /** @type {?TimelineModel.TracingLayer} */ (oldLayersById[payloa d.layer_id]); 128 var layer = /** @type {?TimelineModel.TracingLayer} */ (oldLayersById[payloa d.layer_id]);
129 if (layer) 129 if (layer)
130 layer._reset(payload); 130 layer._reset(payload);
131 else 131 else
132 layer = new TimelineModel.TracingLayer(this.target(), payload); 132 layer = new TimelineModel.TracingLayer(this.target(), payload);
133 this._layersById[payload.layer_id] = layer; 133 this._layersById[payload.layer_id] = layer;
134 if (payload.owner_node) 134 if (payload.owner_node)
135 layer._setNode(this._backendNodeIdToNode.get(payload.owner_node) || null); 135 layer._setNode(this.backendNodeIdToNode().get(payload.owner_node) || null) ;
136 if (!this.contentRoot() && layer.drawsContent()) 136 if (!this.contentRoot() && layer.drawsContent())
137 this.setContentRoot(layer); 137 this.setContentRoot(layer);
138 for (var i = 0; payload.children && i < payload.children.length; ++i) 138 for (var i = 0; payload.children && i < payload.children.length; ++i)
139 layer.addChild(this._innerSetLayers(oldLayersById, payload.children[i])); 139 layer.addChild(this._innerSetLayers(oldLayersById, payload.children[i]));
140 return layer; 140 return layer;
141 } 141 }
142 142
143 /** 143 /**
144 * @param {!Set<number>} nodeIdsToResolve 144 * @param {!Set<number>} nodeIdsToResolve
145 * @param {!Object} seenNodeIds 145 * @param {!Object} seenNodeIds
146 * @param {!TimelineModel.TracingLayerPayload} payload 146 * @param {!TimelineModel.TracingLayerPayload} payload
147 */ 147 */
148 _extractNodeIdsToResolve(nodeIdsToResolve, seenNodeIds, payload) { 148 _extractNodeIdsToResolve(nodeIdsToResolve, seenNodeIds, payload) {
149 var backendNodeId = payload.owner_node; 149 var backendNodeId = payload.owner_node;
150 if (backendNodeId && !this._backendNodeIdToNode.has(backendNodeId)) 150 if (backendNodeId && !this.backendNodeIdToNode().has(backendNodeId))
151 nodeIdsToResolve.add(backendNodeId); 151 nodeIdsToResolve.add(backendNodeId);
152 for (var i = 0; payload.children && i < payload.children.length; ++i) 152 for (var i = 0; payload.children && i < payload.children.length; ++i)
153 this._extractNodeIdsToResolve(nodeIdsToResolve, seenNodeIds, payload.child ren[i]); 153 this._extractNodeIdsToResolve(nodeIdsToResolve, seenNodeIds, payload.child ren[i]);
154 } 154 }
155 }; 155 };
156 156
157 /** 157 /**
158 * @implements {SDK.Layer} 158 * @implements {SDK.Layer}
159 * @unrestricted 159 * @unrestricted
160 */ 160 */
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
468 } 468 }
469 469
470 /** 470 /**
471 * @override 471 * @override
472 * @return {boolean} 472 * @return {boolean}
473 */ 473 */
474 drawsContent() { 474 drawsContent() {
475 return this._drawsContent; 475 return this._drawsContent;
476 } 476 }
477 }; 477 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698