Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2138)

Unified Diff: pkg/shelf/test/message_test.dart

Issue 256753004: pkg/shelf: change helper method on Request and Response (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: nevermind Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/shelf/test/message_change_test.dart ('k') | pkg/shelf/test/request_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/shelf/test/message_test.dart
diff --git a/pkg/shelf/test/message_test.dart b/pkg/shelf/test/message_test.dart
index 1db286ba4495ca691c3b5978e38138352cca577b..d393388e8d96589327f40bab7fad6e2469201b26 100644
--- a/pkg/shelf/test/message_test.dart
+++ b/pkg/shelf/test/message_test.dart
@@ -10,10 +10,16 @@ import 'dart:convert';
import 'package:shelf/src/message.dart';
import 'package:unittest/unittest.dart';
+import 'test_util.dart';
+
class _TestMessage extends Message {
_TestMessage(Map<String, String> headers, Map<String, Object> context,
Stream<List<int>> body)
: super(body, headers: headers, context: context);
+
+ Message change({Map<String, String> headers, Map<String, Object> context}) {
+ throw new UnimplementedError();
+ }
}
Message _createMessage({Map<String, String> headers,
@@ -76,10 +82,10 @@ void main() {
var request = _createMessage(body: controller.stream);
expect(request.readAsString(), completion(equals("hello, world")));
- controller.add([104, 101, 108, 108, 111, 44]);
+ controller.add(HELLO_BYTES);
return new Future(() {
controller
- ..add([32, 119, 111, 114, 108, 100])
+ ..add(WORLD_BYTES)
..close();
});
});
@@ -114,14 +120,14 @@ void main() {
var controller = new StreamController();
var request = _createMessage(body: controller.stream);
expect(request.read().toList(), completion(equals([
- [104, 101, 108, 108, 111, 44],
- [32, 119, 111, 114, 108, 100]
+ HELLO_BYTES,
+ WORLD_BYTES
])));
- controller.add([104, 101, 108, 108, 111, 44]);
+ controller.add(HELLO_BYTES);
return new Future(() {
controller
- ..add([32, 119, 111, 114, 108, 100])
+ ..add(WORLD_BYTES)
..close();
});
});
« no previous file with comments | « pkg/shelf/test/message_change_test.dart ('k') | pkg/shelf/test/request_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698