pkg/shelf: change helper method on Request and Response

pkg/shelf/test/request_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library shelf.request_test;
 
 import 'dart:async';
 
 import 'package:shelf/shelf.dart';
 import 'package:unittest/unittest.dart';
 
+import 'test_change.dart';
 import 'test_util.dart';
 
 Request _request([Map<String, String> headers, Stream<List<int>> body]) {
   return new Request("GET", LOCALHOST_URI, headers: headers, body: body);
 }
 
 void main() {
   group('constructor', () {
     test('protocolVersion defaults to "1.1"', () {
       var request = new Request('GET', LOCALHOST_URI);
@@ skipping 107 matching lines @@
 
     test("comes from the Last-Modified header", () {
       var request = _request({
         'if-modified-since': 'Sun, 06 Nov 1994 08:49:37 GMT'
       });
       expect(request.ifModifiedSince,
           equals(DateTime.parse("1994-11-06 08:49:37z")));
     });
   });
 
-  group("readAsString", () {
-    test("supports a null body", () {
-      var request = _request();
-      expect(request.readAsString(), completion(equals("")));
-    });
+  group('change', () {
+    test('with no arguments returns instance with equal values', () {
+      var controller = new StreamController();
 
-    test("supports a Stream<List<int>> body", () {
-      var controller = new StreamController();
-      var request = _request({}, controller.stream);
-      expect(request.readAsString(), completion(equals("hello, world")));
+      var uri = Uri.parse('https://test.example.com/static/file.html');
 
-      controller.add([104, 101, 108, 108, 111, 44]);
+      var request = new Request('GET', uri,
+          protocolVersion: '2.0',
+          headers: {'header1': 'header value 1'},
+          url: Uri.parse('/file.html'),
+          scriptName: '/static',
+          body: controller.stream,
+          context: {'context1': 'context value 1'});
+
+      var copy = request.change();
+
+      expect(copy.method, request.method);
+      expect(copy.requestedUri, request.requestedUri);
+      expect(copy.protocolVersion, request.protocolVersion);
+      expect(copy.headers, same(request.headers));
+      expect(copy.url, request.url);
+      expect(copy.scriptName, request.scriptName);
+      expect(copy.context, same(request.context));
+      expect(copy.readAsString(), completion('hello, world'));
+
+      controller.add(HELLO_BYTES);
       return new Future(() {
         controller
-          ..add([32, 119, 111, 114, 108, 100])
+          ..add(WORLD_BYTES)
           ..close();
       });
     });
-  });
 
-  group("read", () {
-    test("supports a null body", () {
-      var request = _request();
-      expect(request.read().toList(), completion(isEmpty));
-    });
-
-    test("supports a Stream<List<int>> body", () {
-      var controller = new StreamController();
-      var request = _request({}, controller.stream);
-      expect(request.read().toList(), completion(equals([
-        [104, 101, 108, 108, 111, 44],
-        [32, 119, 111, 114, 108, 100]
-      ])));
-
-      controller.add([104, 101, 108, 108, 111, 44]);
-      return new Future(() {
-        controller
-          ..add([32, 119, 111, 114, 108, 100])
-          ..close();
-      });
+    testChange(({headers, context}) {

[nweiz, 2014/04/29 19:48:48]

Why are these named parameters?

[kevmoo, 2014/04/30 14:27:52]

They align exactly with the shared ctor signature.

+      return new Request('GET', LOCALHOST_URI, headers: headers,
+          context: context);
     });
   });
 }