Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 256753002: Merge v8utils.* and utils.* (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Merge v8utils.* and utils.* BUG=none R=mstarzinger@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=20968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+693 lines, -768 lines) Patch
M src/arm/lithium-codegen-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/global-handles.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/json-stringifier.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/spaces.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sweeper-thread.h View 1 chunk +1 line, -1 line 0 comments Download
M src/uri.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils.h View 1 chunk +438 lines, -0 lines 0 comments Download
M src/utils.cc View 2 chunks +241 lines, -1 line 0 comments Download
M src/v8.h View 1 chunk +1 line, -1 line 0 comments Download
D src/v8utils.h View 1 chunk +0 lines, -475 lines 0 comments Download
D src/v8utils.cc View 1 chunk +0 lines, -276 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-log.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-25 10:46:39 UTC) #1
Michael Starzinger
LGTM.
6 years, 8 months ago (2014-04-25 10:56:55 UTC) #2
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-25 10:57:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20968 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698