Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: ui/app_list/presenter/BUILD.gn

Issue 2567523002: mash: Have chrome set itself as the app list presenter. (Closed)
Patch Set: Address comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/app_list/presenter/BUILD.gn
diff --git a/ui/app_list/presenter/BUILD.gn b/ui/app_list/presenter/BUILD.gn
index 521ab5ed39ad48bea5e9e196a48669d7d56b4faf..2f7b0e7485775d62836c96b05f392ec37fdc2393 100644
--- a/ui/app_list/presenter/BUILD.gn
+++ b/ui/app_list/presenter/BUILD.gn
@@ -8,8 +8,23 @@ import("//testing/test.gni")
assert(use_aura)
+mojom("mojom") {
+ sources = [
+ "app_list_presenter.mojom",
+ ]
+ deps = [
+ "//services/ui/public/interfaces",
+ ]
+
+ export_class_attribute = "APP_LIST_PRESENTER_EXPORT"
mfomitchev 2016/12/12 22:59:49 Cool. Are these new in mojo? Are they actually nec
msw 2016/12/12 23:47:54 I don't know how new they are; but they fixed my c
mfomitchev 2016/12/13 01:14:13 Thanks for the explanation.
+ export_define = "APP_LIST_PRESENTER_IMPLEMENTATION=1"
+ export_header = "ui/app_list/presenter/app_list_presenter_export.h"
+}
+
component("presenter") {
sources = [
+ "app_list.cc",
+ "app_list.h",
"app_list_presenter.h",
"app_list_presenter_delegate.cc",
"app_list_presenter_delegate.h",
@@ -24,7 +39,9 @@ component("presenter") {
defines = [ "APP_LIST_PRESENTER_IMPLEMENTATION" ]
public_deps = [
+ ":mojom",
"//base",
+ "//mojo/public/cpp/bindings",
"//ui/app_list",
"//ui/aura",
"//ui/compositor",
@@ -37,15 +54,6 @@ component("presenter") {
]
}
-mojom("mojom") {
- sources = [
- "app_list_presenter.mojom",
- ]
- deps = [
- "//services/ui/public/interfaces",
- ]
-}
-
static_library("test_support") {
sources = [
"test/app_list_presenter_impl_test_api.cc",

Powered by Google App Engine
This is Rietveld 408576698