Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: third_party/WebKit/Source/core/css/CSSProperties.in

Issue 2567473002: Made a generator for CSSPropertyDescriptor.cpp (Closed)
Patch Set: format Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSProperties.in
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.in b/third_party/WebKit/Source/core/css/CSSProperties.in
index 317166e24ffee690fddb94a1ee2971ae8ad1b8db..f4e0fc747db7e01f2e5e98f9e36e06278bd627d0 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.in
+++ b/third_party/WebKit/Source/core/css/CSSProperties.in
@@ -23,6 +23,17 @@
// The property is a shorthand for several other properties.
+// - api_class[=classname]
+// Specifies the existance (and optionally name) of a CSSPropertyAPI implementation for the property to be used by make_css_property_descriptor.py.
sashab 2016/12/13 23:10:38 Wrap to 80 (check?) characters Copy rest of file
aazzam 2016/12/13 23:27:53 done :)
+// See core/css/properties/CSSPropertyAPI.h for API details.
+// * Add this flag if the API has been implemented for this property.
+// * If the classname for this is different to the name of the property, specify a
+// value for this flag. e.g. api_class=CSSPropertyAPIWebkitPadding
+// TODO(aazzam): When most properties have been implemented, modify this so that
+// properties with default classnames do not get this flag, and introduce a
+// 'not_implemented' flag instead.
+
+
// - keyword_only
// These properties only store keyword values. This is used when
// generating the ComputedStyle storage for the property. The initial
@@ -469,10 +480,10 @@ z-index interpolable, type_name=int, custom_all
-webkit-margin-start direction_aware
-webkit-margin-before direction_aware
-webkit-margin-after direction_aware
--webkit-padding-end direction_aware
--webkit-padding-start direction_aware
--webkit-padding-before direction_aware
--webkit-padding-after direction_aware
+-webkit-padding-end direction_aware, api_class=CSSPropertyAPIWebkitPadding
sashab 2016/12/13 23:10:38 This is so much better!! Yay!
+-webkit-padding-start direction_aware, api_class=CSSPropertyAPIWebkitPadding
+-webkit-padding-before direction_aware, api_class=CSSPropertyAPIWebkitPadding
+-webkit-padding-after direction_aware, api_class=CSSPropertyAPIWebkitPadding
-webkit-logical-width direction_aware
-webkit-logical-height direction_aware
-webkit-min-logical-width direction_aware

Powered by Google App Engine
This is Rietveld 408576698