Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: third_party/WebKit/Source/core/css/CSSProperties.in

Issue 2567473002: Made a generator for CSSPropertyDescriptor.cpp (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSProperties.in
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.in b/third_party/WebKit/Source/core/css/CSSProperties.in
index 76b3e3b41858cc47cf4fe7617025bade64800f98..f46c40a8fe708a99d4b570bb19e323ec3ec6db0b 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.in
+++ b/third_party/WebKit/Source/core/css/CSSProperties.in
@@ -23,6 +23,19 @@
// The property is a shorthand for several other properties.
+// - generated_api_class[=group]
+// We have a CSSPropertyAPI interface which contains parsing functions for
+// properties, and will be implemented by all CSS properties.
+// * When we want to generate the .h file for a property, we add this flag.
sashab 2016/12/08 23:56:35 Small nit: instead of saying "we", phrase stuff li
aazzam 2016/12/09 00:44:39 tried re-wording, ptal :)
+// * Properties which have the same parsing logic should be grouped together when
+// generating an API .h file for the property. If the specified property is in
+// a group, the value of that flag should be set to the group name - all of
sashab 2016/12/08 23:56:35 Remove double space before value Also explain tha
+// the properties with this flag value will inherit from a class with this name.
+// * Properties which are not generated do not get this flag.
+// TODO(aazzam): Once all .h files are generated, change this so that only grouped
+// properties have this flag and introduce a 'not_generated' flag instead.
+
+
// - keyword_only
// These properties only store keyword values. This is used when
// generating the ComputedStyle storage for the property. The initial
@@ -468,10 +481,10 @@ z-index interpolable, type_name=int, custom_all
-webkit-margin-start direction_aware
-webkit-margin-before direction_aware
-webkit-margin-after direction_aware
--webkit-padding-end direction_aware
--webkit-padding-start direction_aware
--webkit-padding-before direction_aware
--webkit-padding-after direction_aware
+-webkit-padding-end direction_aware, generated_api_class=WebkitPadding
+-webkit-padding-start direction_aware, generated_api_class=WebkitPadding
+-webkit-padding-before direction_aware, generated_api_class=WebkitPadding
+-webkit-padding-after direction_aware, generated_api_class=WebkitPadding
-webkit-logical-width direction_aware
-webkit-logical-height direction_aware
-webkit-min-logical-width direction_aware

Powered by Google App Engine
This is Rietveld 408576698