Made a generator for CSSPropertyDescriptor.cpp

third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-
 #include "core/css/properties/CSSPropertyDescriptor.h"
 
-#include "core/css/properties/CSSPropertyAPIPadding.h"
+{% for api_class in api_classes %}
+#include "core/css/properties/{{api_class.classname}}.h"
+{% endfor %}
 
 namespace blink {
 
-// Initialises a CSSPropertyDescriptor. When functions are added to
-// CSSPropertyAPI, also add them to the struct initaliser below.
-#define GET_DESCRIPTOR(X) \
-  { X::parseSingleValue, true }
-
-// Initialises an invalid CSSPropertyDescriptor. When functions are added to
-// CSSPropertyAPI, add a nullptr to represent their function pointers in the
-// struct initaliser.
-#define GET_INVALID_DESCRIPTOR() \
-  { nullptr, false }
-
 static_assert(
     std::is_pod<CSSPropertyDescriptor>::value,
     "CSSPropertyDescriptor must be a POD to support using initializer lists.");
 
 static CSSPropertyDescriptor cssPropertyDescriptors[] = {
-    GET_INVALID_DESCRIPTOR(), GET_DESCRIPTOR(CSSPropertyAPIWebkitPadding),
+    // Initialises an invalid CSSPropertyDescriptor. When functions are added to
+    // CSSPropertyAPI, add a nullptr to represent their function pointers in the
+    // struct initaliser.
+    { nullptr, false },
+    {% for api_class in api_classes %}
+
+    // Initialises a CSSPropertyDescriptor. When functions are added to
+    // CSSPropertyAPI, also add them to the struct initaliser below.

[alancutter (OOO until 2018), 2016/12/13 22:35:22]

These two comments need to be reworded for their new context. They sound very
strange now.

[aazzam, 2016/12/13 22:48:57]

I changed them a bit, does it sound better now?

+    { {{api_class.classname}}::parseSingleValue, true }
+    {% endfor %}
 };
 
 const CSSPropertyDescriptor& CSSPropertyDescriptor::get(CSSPropertyID id) {
   // TODO(aazzam): We are currently using hard-coded indexes for
   // cssPropertyDescriptor since we have only implemented a few properties.
   // Later, generate this switch statement, or alternatively return
   // cssPropertyDescriptors[id], and generate the cssPropertyDescriptors array
   // to hold invalid descriptors for methods which haven't been implemented yet.
   switch (id) {
-    case CSSPropertyWebkitPaddingEnd:
-      return cssPropertyDescriptors[1];
-    case CSSPropertyWebkitPaddingStart:
-      return cssPropertyDescriptors[1];
-    case CSSPropertyWebkitPaddingBefore:
-      return cssPropertyDescriptors[1];
-    case CSSPropertyWebkitPaddingAfter:
-      return cssPropertyDescriptors[1];
+    {% for api_class in api_classes %}
+    {% for property_id in api_class.property_ids %}
+    case {{property_id}}:
+    {% endfor %}
+      return cssPropertyDescriptors[{{api_class.index}}];
+        {% endfor %}
     default:
       return cssPropertyDescriptors[0];
   }
 }
 
 }  // namespace blink