Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2567453002: Revert of Make InvalidatableInterpolation's InterpolationTypes decided at effect application time (Closed)

Created:
4 years ago by alancutter (OOO until 2018)
Modified:
4 years ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make InvalidatableInterpolation's InterpolationTypes decided at effect application time (patchset #3 id:40001 of https://codereview.chromium.org/2555923003/ ) Reason for revert: Broke the mac compile bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/180366/steps/compile/logs/stdio Original issue's description: > Make InvalidatableInterpolation's InterpolationTypes decided at effect application time > > This patch replaces PropertyInterpolationTypesMapping with CSS and SVG > InterpolationTypesMap classes that are provided to InvalidatableInterpolation > objects via the InterpolationEnvironment. > > InvalidatableInterpolations are no longer provided with the list of > InterpolationTypes at construction, now they retrieve the list at effect > application time during applyStack(). > > This is in preparation for supporting smooth animation of registered > custom properties. > > BUG=671904 > > Committed: https://crrev.com/3ac8b90fcbda4c6e3ef484140751cd0341b31c48 > Cr-Commit-Position: refs/heads/master@{#437381} TBR=ericwilligers@chromium.org,timloh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=671904 Committed: https://crrev.com/4899212e500b0738e617349ced2318e018ab317a Cr-Commit-Position: refs/heads/master@{#437393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -590 lines) Patch
M third_party/WebKit/Source/core/animation/BUILD.gn View 4 chunks +2 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.h View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp View 1 chunk +0 lines, -298 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationEnvironment.h View 3 chunks +4 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/core/animation/InterpolationTypesMap.h View 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp View 7 chunks +3 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Keyframe.cpp View 2 chunks +3 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.h View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp View 1 chunk +427 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/animation/SVGInterpolationTypesMap.h View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/core/animation/SVGInterpolationTypesMap.cpp View 1 chunk +0 lines, -157 lines 0 comments Download
M third_party/WebKit/Source/core/css/PropertyRegistry.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alancutter (OOO until 2018)
Created Revert of Make InvalidatableInterpolation's InterpolationTypes decided at effect application time
4 years ago (2016-12-08 23:13:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567453002/1
4 years ago (2016-12-08 23:14:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 23:15:31 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4899212e500b0738e617349ced2318e018ab317a Cr-Commit-Position: refs/heads/master@{#437393}
4 years ago (2016-12-08 23:17:08 UTC) #7
findit-for-me
FYI: Findit identified this CL at revision 437393 as the culprit for failures in the ...
4 years ago (2016-12-08 23:36:37 UTC) #8
alancutter (OOO until 2018)
4 years ago (2016-12-09 00:19:55 UTC) #9
Message was sent while issue was closed.
On 2016/12/08 at 23:36:37, findit-for-me wrote:
> FYI: Findit identified this CL at revision 437393 as the culprit for
> failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

A fix of this revert has been landed in:
https://codereview.chromium.org/2559393002

Powered by Google App Engine
This is Rietveld 408576698