Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/testing/dart/multitest.dart

Issue 256743009: Cache output of dart2js compilations that went wrong on disk. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/multitest.dart
===================================================================
--- tools/testing/dart/multitest.dart (revision 35513)
+++ tools/testing/dart/multitest.dart (working copy)
@@ -248,9 +248,13 @@
if (!importDir.isEmpty) {
TestUtils.mkdirRecursive(targetDir, importDir);
}
+ Path srcPath = sourceDir.join(importPath);
+ Path targetPath = targetDir.join(importPath);
// Copy file.
- futureCopies.add(TestUtils.copyFile(sourceDir.join(importPath),
- targetDir.join(importPath)));
+ Future copy = TestUtils.isContentEqual(srcPath, targetPath).then((equal) {
Bill Hesse 2014/04/29 17:51:55 It seems to me that "copyIfDifferent" is a useful
ricow1 2014/04/30 06:51:01 Done.
+ return equal ? null : TestUtils.copyFile(srcPath, targetPath);
+ });
+ futureCopies.add(copy);
}
// Wait until all imports are copied before scheduling test cases.

Powered by Google App Engine
This is Rietveld 408576698