Issue 256743007: arm: Fix Smi check in SubStringStub::Generate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 256743007: arm: Fix Smi check in SubStringStub::Generate (Closed)

Created:
6 years, 7 months ago by Jakob Kummerow

Modified:
6 years, 7 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	src/arm/code-stubs-arm.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

PTAL. Test coverage coming up in https://codereview.chromium.org/252143002.

6 years, 7 months ago (2014-04-29 12:12:31 UTC) #1

Jakob Kummerow

6 years, 7 months ago (2014-04-29 13:42:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21050 (presubmit successful).