Issue 25674019: Make sure to show the correct URL from CVC.

Issue 25674019: Make sure to show the correct URL from CVC. (Closed)

Created:
7 years, 2 months ago by David Trainor- moved to gerrit

Modified:
7 years, 2 months ago

Reviewers:
Ted C, Charlie Reis

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make sure to show the correct URL from CVC. We should be showing the URL of the visible entry not the active entry. BUG=304226 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227333

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed comment, made simpler #

Patch Set 3 : Moved whole file to GetVisibleEntry #

Patch Set 4 : Rebased #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -9 lines)			Patch
	M	content/browser/android/content_view_core_impl.cc	View	1 2 3	4 chunks	+4 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

LGTM https://chromiumcodereview.appspot.com/25674019/diff/1/content/browser/android/content_view_core_impl.cc File content/browser/android/content_view_core_impl.cc (right): https://chromiumcodereview.appspot.com/25674019/diff/1/content/browser/android/content_view_core_impl.cc#newcode826 content/browser/android/content_view_core_impl.cc:826: // rather than the visible entry, which is ...

7 years, 2 months ago (2013-10-04 20:31:47 UTC) #2

David Trainor- moved to gerrit

https://chromiumcodereview.appspot.com/25674019/diff/1/content/browser/android/content_view_core_impl.cc File content/browser/android/content_view_core_impl.cc (right): https://chromiumcodereview.appspot.com/25674019/diff/1/content/browser/android/content_view_core_impl.cc#newcode826 content/browser/android/content_view_core_impl.cc:826: // rather than the visible entry, which is exposed ...

7 years, 2 months ago (2013-10-04 20:50:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/25674019/14001

7 years, 2 months ago (2013-10-07 20:23:03 UTC) #5

Message was sent while issue was closed.

Change committed as 227333

Expand Messages | Collapse Messages