runtime/lib/object.cc - Issue 25674017: Fix runtimeType for strings, integers and double: return their interface type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/object.cc

Issue 25674017: Fix runtimeType for strings, integers and double: return their interface type. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/object.cc

===================================================================

--- runtime/lib/object.cc (revision 28266)

+++ runtime/lib/object.cc (working copy)

@@ -93,6 +93,8 @@

DEFINE_NATIVE_ENTRY(Object_runtimeType, 1) {

const Instance& instance = Instance::CheckedHandle(arguments->NativeArgAt(0));

+ // Special handling for following types outside this native.

+ ASSERT(!instance.IsString() && !instance.IsInteger() && !instance.IsDouble());

const Type& type = Type::Handle(instance.GetType());

// The static type of null is specified to be the bottom type, however, the

// runtime type of null is the Null type, which we correctly return here.

« no previous file with comments | « runtime/lib/mirrors_impl.dart ('k') | runtime/lib/string_patch.dart » ('j') | no next file with comments »