Fix runtimeType for strings, integers and double: return their interface type.

runtime/lib/mirrors_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // VM-specific implementation of the dart:mirrors library.
 
 import "dart:collection";
 
 // These values are allowed to be passed directly over the wire.
 bool _isSimpleValue(var value) {
@@ skipping 324 matching lines @@
 
   _invoke(reflectee, functionName, arguments, argumentNames)
       native 'InstanceMirror_invoke';
 
   _invokeGetter(reflectee, getterName)
       native 'InstanceMirror_invokeGetter';
 
   _invokeSetter(reflectee, setterName, value)
       native 'InstanceMirror_invokeSetter';
 
-  static _computeType(reflectee)
-      native 'Object_runtimeType';
+  static _computeType(reflectee) => reflectee.runtimeType;

[rmacnak, 2013/10/04 16:49:56]

Please don't change this. The mirrors should retrieve the object's true type,
even if a user overrides runtimeType. We're missing test coverage for this, so
I'll add it.

[siva, 2013/10/04 16:56:34]

I thought we don't allow end users to override methods in core
classes like Integer, String, Bool etc.

On 2013/10/04 16:49:56, Ryan Macnak wrote:

[rmacnak, 2013/10/04 17:11:50]

We don't, and the changes to the built-in types are fine. What I'm saying is the
following should pass:

import 'dart:mirrors';
import 'package:expect/expect.dart';

class NotAString {
  Type get runtimeType => String;
}
main(){
  Expect.equals(String,
                new NotAString().runtimeType);
  Expect.equals(reflectClass(NotAString),
                reflect(new NotAString()).type);
}

So _computeType should go to the native, rather than calling runtimeType on the
reflectee.

Whether reflectClass(String) == reflect('str').type is an implementation detail.
(Which will happen to be false on the VM and true in dart2js.)

On 2013/10/04 16:56:34, siva wrote:

[Ivan Posva, 2013/10/04 17:49:55]

Ryan,

In that case you should be calling your own native method and not be relying on
the method of Object. Also note that you were calling a instance native from a
static method, which is another problem.

-Ivan

 }
 
 class _LocalClosureMirrorImpl extends _LocalInstanceMirrorImpl
     implements ClosureMirror {
   _LocalClosureMirrorImpl(reflectee) : super(reflectee);
 
   MethodMirror _function;
   MethodMirror get function {
     if (_function == null) {
       _function = _computeFunction(reflectee);
@@ skipping 964 matching lines @@
     if (typeMirror == null) {
       typeMirror = makeLocalTypeMirror(key);
       _instanitationCache[key] = typeMirror;
       if (typeMirror is ClassMirror && !typeMirror._isGeneric) {
         _declarationCache[key] = typeMirror;
       }
     }
     return typeMirror;
   }
 }