Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 25674007: Remove core/platform/text/{mac, win} (Closed)

Created:
7 years, 2 months ago by abarth-chromium
Modified:
7 years, 2 months ago
Reviewers:
adamk
CC:
blink-reviews
Visibility:
Public.

Description

Remove core/platform/text/{mac, win} These directories only exist to contain LocaleMac and LocaleWin, respectively. We can just move those files to be next to LocaleICU. R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158838

Patch Set 1 #

Patch Set 2 : Fix includes #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1150 lines) Patch
M Source/core/core.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/core.gypi View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + Source/core/platform/text/LocaleMac.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/platform/text/LocaleMac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/platform/text/LocaleWin.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/platform/text/LocaleWin.cpp View 1 2 5 chunks +18 lines, -13 lines 0 comments Download
D Source/core/platform/text/mac/LocaleMac.h View 1 chunk +0 lines, -104 lines 0 comments Download
D Source/core/platform/text/mac/LocaleMac.mm View 1 chunk +0 lines, -332 lines 0 comments Download
D Source/core/platform/text/win/LocaleWin.h View 1 chunk +0 lines, -101 lines 0 comments Download
D Source/core/platform/text/win/LocaleWin.cpp View 1 2 1 chunk +0 lines, -587 lines 0 comments Download
M Source/web/tests/LocaleMacTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/LocaleWinTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
abarth-chromium
7 years, 2 months ago (2013-10-02 20:58:17 UTC) #1
adamk
lgtm
7 years, 2 months ago (2013-10-02 20:58:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25674007/1
7 years, 2 months ago (2013-10-02 20:58:56 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-02 21:22:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25674007/16001
7 years, 2 months ago (2013-10-02 22:46:35 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=6495
7 years, 2 months ago (2013-10-02 23:54:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25674007/16001
7 years, 2 months ago (2013-10-03 01:30:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25674007/16001
7 years, 2 months ago (2013-10-03 05:42:58 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=8477
7 years, 2 months ago (2013-10-03 09:31:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25674007/16001
7 years, 2 months ago (2013-10-03 15:37:29 UTC) #10
commit-bot: I haz the power
Failed to apply patch for Source/core/platform/text/LocaleWin.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; A Source/core/platform/text/LocaleWin.cpp ...
7 years, 2 months ago (2013-10-03 15:37:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25674007/44001
7 years, 2 months ago (2013-10-03 19:05:06 UTC) #12
abarth-chromium
7 years, 2 months ago (2013-10-03 20:22:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 manually as r158838 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698