Improve document for HashSet.

Improve document for HashSet.

See #28083 (http://dartbug.com/28083)

R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/7ee023d2ede0d13fefb5e2c0b3efa22ac4025f79

[floitsch, 2016-12-13 13:13:07]

floitsch@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2016-12-13 14:01:33]

lgtm

https://codereview.chromium.org/2567393002/diff/1/sdk/lib/collection/hash_set...
File sdk/lib/collection/hash_set.dart (right):

https://codereview.chromium.org/2567393002/diff/1/sdk/lib/collection/hash_set...
sdk/lib/collection/hash_set.dart:114: * the one in the resulting set.
Good idea.

https://codereview.chromium.org/2567393002/diff/1/sdk/lib/collection/hash_set...
sdk/lib/collection/hash_set.dart:116: * The iteration order of the resulting set
is undetermined and depends on
I don't think we have used "undetermined" anywhere before. Maybe "implementation
dependent" or just "not specified' or "not guaranteed".

https://codereview.chromium.org/2567393002/diff/1/sdk/lib/collection/hash_set...
sdk/lib/collection/hash_set.dart:119: * the set is not modified.
I'm not sure we need to repeat what unordered set means in every constructor.
That said, it's not really *repeating* since we haven't spelled it out anywhere.
How about moving this paragraph to the class description instead of here?

[floitsch, 2016-12-13 14:08:31]

https://codereview.chromium.org/2567393002/diff/1/sdk/lib/collection/hash_set...
File sdk/lib/collection/hash_set.dart (right):

https://codereview.chromium.org/2567393002/diff/1/sdk/lib/collection/hash_set...
sdk/lib/collection/hash_set.dart:114: * the one in the resulting set.
On 2016/12/13 14:01:33, Lasse Reichstein Nielsen wrote:
> Good idea.

Acknowledged.

https://codereview.chromium.org/2567393002/diff/1/sdk/lib/collection/hash_set...
sdk/lib/collection/hash_set.dart:116: * The iteration order of the resulting set
is undetermined and depends on
On 2016/12/13 14:01:33, Lasse Reichstein Nielsen wrote:
> I don't think we have used "undetermined" anywhere before. Maybe
"implementation
> dependent" or just "not specified' or "not guaranteed".

not specified.

https://codereview.chromium.org/2567393002/diff/1/sdk/lib/collection/hash_set...
sdk/lib/collection/hash_set.dart:119: * the set is not modified.
On 2016/12/13 14:01:33, Lasse Reichstein Nielsen wrote:
> I'm not sure we need to repeat what unordered set means in every constructor.
> That said, it's not really *repeating* since we haven't spelled it out
anywhere.
> How about moving this paragraph to the class description instead of here?
> 

Done.

[floitsch, 2016-12-13 14:09:02]

Description was changed from

==========
Improve document for HashSet.

See #28083 (http://dartbug.com/28083)
==========

to

==========
Improve document for HashSet.

See #28083 (http://dartbug.com/28083)

R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7ee023d2ede0d13fefb5e2c0b3efa22ac4025f79
==========

[floitsch, 2016-12-13 14:09:04]

Committed patchset #2 (id:20001) manually as
7ee023d2ede0d13fefb5e2c0b3efa22ac4025f79 (presubmit successful).