Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Unified Diff: components/ntp_tiles/most_visited_sites.h

Issue 2567333003: ntp_tiles: Refactor existing MostVisitedSites tests (Closed)
Patch Set: Rebased. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ntp_tiles/most_visited_sites_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_tiles/most_visited_sites.h
diff --git a/components/ntp_tiles/most_visited_sites.h b/components/ntp_tiles/most_visited_sites.h
index 27a98c1f1b406641da00dba576dda7ea4fa0d0ba..9d0aaad168e35251d8a5d1e283849a909b72a343 100644
--- a/components/ntp_tiles/most_visited_sites.h
+++ b/components/ntp_tiles/most_visited_sites.h
@@ -116,9 +116,13 @@ class MostVisitedSites : public history::TopSitesObserver,
static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
- private:
- friend class MostVisitedSitesTest;
+ // Workhorse for SaveNewTiles. Implemented as a separate static and public
+ // method for ease of testing.
+ static NTPTilesVector MergeTiles(NTPTilesVector personal_tiles,
+ NTPTilesVector whitelist_tiles,
+ NTPTilesVector popular_tiles);
+ private:
void BuildCurrentTiles();
// Initialize the query to Top Sites. Called if the SuggestionsService
@@ -150,12 +154,6 @@ class MostVisitedSites : public history::TopSitesObserver,
// if appropriate, and saves the new tiles.
void SaveNewTiles(NTPTilesVector personal_tiles);
- // Workhorse for SaveNewTiles above. Implemented as a separate static method
- // for ease of testing.
- static NTPTilesVector MergeTiles(NTPTilesVector personal_tiles,
- NTPTilesVector whitelist_tiles,
- NTPTilesVector popular_tiles);
-
// Notifies the observer about the availability of tiles.
// Also records impressions UMA if not done already.
void NotifyMostVisitedURLsObserver();
« no previous file with comments | « no previous file | components/ntp_tiles/most_visited_sites_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698