Issue 25673002: Revert 226376 "[rAC, OSX] saveInChrome status now persistent."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25673002: Revert 226376 "[rAC, OSX] saveInChrome status now persistent." (Closed)

Created:
7 years, 2 months ago by piman

Modified:
7 years, 2 months ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 226376 "[rAC, OSX] saveInChrome status now persistent." Broke the mac build: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests%20%282%29&number=42927 > [rAC, OSX] saveInChrome status now persistent. > > The AutofillDialogController already persisted the state of the > "Save in Chrome" checkbox. This CL ensures that the OSX dialog reflects > that persisted state and is properly updated when the state changes. > > NOTRY=true > BUG=282101 > R=avi@chromium.org > > Review URL: https://codereview.chromium.org/25405003 TBR=groby@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226385

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -12 lines)			Patch
M	trunk/src/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/cocoa/autofill/autofill_main_container.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/cocoa/autofill/autofill_main_container.mm	View	3 chunks	+2 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

LGTM. Sadly.