battre
2017/01/12 08:12:55
Do we really want to store this in prefs? Any upda
Do we really want to store this in prefs? Any update will trigger a rewrite of
prefs and prefs are not particularly fast to read and write.
Also, please make sure that clearing your browsing data (i.e. history) erases
all buffered UKMs.
Steven Holte
2017/01/13 23:15:26
I'm pretty much just reusing the UMA logic here.
On 2017/01/12 08:12:55, battre wrote:
> Do we really want to store this in prefs? Any update will trigger a rewrite of
> prefs and prefs are not particularly fast to read and write.
>
> Also, please make sure that clearing your browsing data (i.e. history) erases
> all buffered UKMs.
I'm pretty much just reusing the UMA logic here. These logs are generated on a
similar interval to UMA (about every 5 minutes), and usually only get persisted
to disk on shutdown/background, so I wouldn't expect the pref write overhead to
be too large, but I'd be interested if there is a better suggestion for where to
persist buffered logs.
Added code to clear this data on Clear Browsing History.
Issue 2567263003: Basic UkmService implementation
(Closed)
Created 4 years ago by Steven Holte
Modified 3 years, 11 months ago
Reviewers: rkaplow, Zhen Wang, Alexei Svitkine (slow), oystein (OOO til 10th of July), battre, Olivier, sdefresne, Nico
Base URL:
Comments: 114